Repository navigation
Add support for tapo bulbs - #558
rytilahti merged 19 commits into
Conversation
Sorry, something went wrong.
Codecov ReportAttention: 23 lines in your changes are missing coverage. Please review.
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 79.66% 79.56% -0.11%
==========================================
Files 36 37 +1
Lines 2995 3083 +88
Branches 779 804 +25
==========================================
+ Hits 2386 2453 +67
- Misses 536 548 +12
- Partials 73 82 +9 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
|
The bulbs are organized to separate categories for testing depending on the available features. I think this requires some restructuring to avoid duplicating the categorization per device family, perhaps this should wait until we have device type interfaces in place. |
Sorry, something went wrong.
Activating the effect does not work as I thought it would, but this implements rest of the interface from SmartLightStrip.
|
Oddly enough, the discovery response differs from the sysinfo response on the model information. Anyway, I think we should just merge and continue improving it in other PRs. |
Sorry, something went wrong.
Do you mean discovery has (EU) on the end and get_device_info doesn't? That's how I got tripped up dropping the region from the fixture name. Other than that everything else looks great. I've just put comments here but in future do you want me to start a review and approve etc? |
Sorry, something went wrong.
Ahh, indeed, didn't notice that but it's a non-issue! :-)
Great, thanks! Sure thing, an extra pair of eyes looking over the changes is always appreciated. I'll merge this now and leave further improvements and cleanups for future PRs. |
Sorry, something went wrong.
* Add support for tapo light bulbs * Use TapoDevice for on/off * Add tapobulbs to discovery * Add partial support for effects Activating the effect does not work as I thought it would, but this implements rest of the interface from SmartLightStrip. * Add missing __init__ for tapo package * Make mypy happy * Add docstrings to make ruff happy * Implement state_information and has_emeter * Import tapoplug from kasa.tapo package * Add tapo L530 fixture * Enable tests for L530 fixture * Make ruff happy * Update fixture filename * Raise exceptions on invalid parameters * Return results in a wrapped dict * Implement set_* * Reorganize bulbs to iot&smart, fix tests for smarts * Fix linting * Fix BULBS_LIGHT_STRIP back to LIGHT_STRIPS
This is a preliminary PR to add support for tapo bulbs.
Basic functionality is tested to work with L530 but this is still a WIP.
Based on #552 which should be merged before this.
Cli output
== smarte WLAN-Glühbirne - L530 == Host: 192.168.xx.xx Port: None Device state: True == Generic information == Time: 2023-12-03 17:09:22+01:00 (tz: {'timezone': 'Europe/Berlin'} Hardware: 3.0 Software: 1.0.6 Build 230509 Rel.195312 MAC (rssi): 5C:E9:31:xx:xx:xx (-38) Location: {'latitude': 0, 'longitude': 0} == Device specific information == Brightness: 100 Is dimmable: True Color temperature: 6000 Valid temperature range: ColorTempRange(min=2500, max=6500) HSV: HSV(hue=0, saturation=100, value=100) Presets: == Current State == Got error: SmartDeviceException('update() required prior accessing emeter')Note, the discovery reports the model as L530E in contrast to sysinfo response.