Repository navigation
Do not automatically add emeter to iot strip - #865
Merged
rytilahti merged 3 commits intoApr 25, 2024
Merged
rytilahti merged 3 commits into
rytilahti merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rytilahti
approved these changes
Apr 25, 2024
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Let's give it a go and fix it later if need to be, it's more important to get the feature-based emeter sensors in the HA PR than whatever special handling we are going to need potentially for HS300.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the current broken tests in #844 caused by the fixtures for HS107(US)_1.0_1.0.8.json and KP400(US)_1.0_1.0.10.json having the emeter value in the fixture but no get_realtime value. Other strips do not fail because they do not have the emeter value in the fixture and the FakeIotProtocol creates one for them.
It seems that #299 introduced the adding of Emeter in the smart strip constructor (in commit c8ad99a) and this was added after #243 which adds the Emeter in the IoDevice update() method so perhaps there is an implication to this change that I'm missing, although it seems _create_emeter_request is no longer called anywhere so maybe that was a historical reason.
N.B. The tests all pass with this PR.
Link to CI run on branch