FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add generic typing support to features by sdb9696 · Pull Request #926 · python-kasa/python-kasa · GitHub

Repository navigation

Add generic typing support to features - #926

Closed
sdb9696 wants to merge 1 commit into
masterfrom
feat/feature_typing
Closed

sdb9696 wants to merge 1 commit into
masterfrom
feat/feature_typing

Conversation

sdb9696 commented May 21, 2024

Copy link
Copy Markdown
Contributor

No description provided.

codecov Bot commented May 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (5e619af) to head (a3a5c5d).
Report is 346 commits behind head on master.

Files with missing lines Patch % Lines
kasa/feature.py 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   91.47%   91.49%   +0.01%     
==========================================
  Files          83       83              
  Lines        5434     5466      +32     
  Branches     1316     1317       +1     
==========================================
+ Hits         4971     5001      +30     
- Misses        362      363       +1     
- Partials      101      102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdb9696 mentioned this pull request May 23, 2024
sdb9696 marked this pull request as draft July 4, 2024 12:34

sdb9696 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

Closing for now as not too pressing, can always revisit.

sdb9696 closed this Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL