[3.3] Fix macOS SDK builds without ldap_init_fd - #363
Merged
encukou merged 0 commit intoJun 29, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
encukou
reviewed
Jun 29, 2020
Comment thread
Doc/reference/ldap.rst
Outdated
encukou
approved these changes
Jun 29, 2020
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS system libldap 2.4.28 does not have ldap_init_fd symbol. Disable
initialize_fd when Apple libldap 2.4.28 is detected.
Also run some macOS tests on Travis CI. Since the SDK does not ship
slapd, testing is rather limited.
Fixes: #359
Signed-off-by: Christian Heimes cheimes@redhat.com