Add retry on EINTR. - #527
Conversation
Sorry, something went wrong.
Try and fix issue python-ldap#242 by adding a retry on EINTR and a sleep before attempting to do so.
similar to original function to pass tests.
|
Apologies for the delay, pretty inexperienced with python. Made some changes to fix tests. |
Sorry, something went wrong.
|
doesn't it already work when you use ldap.ldapobject.ReconnectLDAPObject instead of ldap.ldapobject.SimpleLDAPObject? |
Sorry, something went wrong.
|
I tested with ldap.ldapobject.ReconnectLDAPObject and unfortunately the interrupts still occur and don't seem to retry. The bind action seems to work but a call to say modify a group will throw the error. |
Sorry, something went wrong.
|
Is setting the LDAP_OPT_RESTART option not working? Can you post the backtrace when this happens? |
Sorry, something went wrong.
|
-1 until we know if/when LDAP_OPT_RESTART is (not) enough. Don't want to paper over potential libldap bugs. |
Sorry, something went wrong.
Try and fix issue #242 by adding a retry on EINTR and a sleep before attempting to do so. This is based off of #291.
We happen to come across a few instances of EINTR in our usage every day and would like to add a single retry since it seems all further LDAP calls are successful. Only kept it to a single retry for now, though I could be convinced to raise it.