[WIP] Check and warn if OPT_X_TLS_NEWCTX is required - #64
Closed
tiran wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tiran
force-pushed
the
tls_newctx
branch
12 times, most recently
from
1299d11 to
afd80fd
Compare
December 5, 2017 16:27
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 68.87% 68.95% +0.07%
==========================================
Files 49 49
Lines 4694 4712 +18
Branches 789 794 +5
==========================================
+ Hits 3233 3249 +16
Misses 1111 1111
- Partials 350 352 +2
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tiran
force-pushed
the
tls_newctx
branch
5 times, most recently
from
1ff5c41 to
2522c4f
Compare
December 11, 2017 13:49
Without OPT_X_TLS_NEWCTX, most settings TLS settings are not applied. See python-ldap#55 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Copy link
Copy Markdown
Member
|
What's the progress here? Is it a dead end? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The documentation improvements are now merged. Let's not do the extra checks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #55
Signed-off-by: Christian Heimes cheimes@redhat.com