Change severity level for flake8 errors - #223
Merged
ccordoba12 merged 1 commit intoJun 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ccordoba12
approved these changes
Jun 17, 2022
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for your contribution @jhossbach!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Glad to be of help :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This fix is invalid : with it, every error code Exxx from Flake8 have Error severity level. See https://flake8.pycqa.org/en/latest/user/error-codes.html, https://flake8.pycqa.org/en/latest/glossary.html#term-error-code and https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes Error codes from Flake8 :
The same severity levels are used when pydocstyle and PyFlakes are used directly instead of Flake8 plugin. |
Sorry, something went wrong.
lcheylus
added a commit
to lcheylus/python-lsp-server
that referenced
this pull request
Jun 30, 2022
Error codes from Flake8 :
- Fxxx : checks from PyFlakes => Error severity level
- E999 : code for invalid AST => Error severity level
- Exxx : checks from pydocstyle (syntax checks for PEP-8) => Warning
severity level
- Wxxx : checks from pydocstyle (syntax checks for PEP-8) => Warning
severity level
Closes python-lsp#230
Fix PR python-lsp#223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #220. The severity flag for all flake8 diagnostics are declared as warning. With this PR, all flake8 messages starting with "E" (includes messages from pycodestyle) are parsed with error severity level.
Fixes #220