Add autopep8.enabled to the configuration schema - #225
Merged
ccordoba12 merged 1 commit intoJul 2, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Tests are failing due to a new Numpy release. I'll fix them in another PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Please rebase on top of the latest develop to get the fix to our tests in PR #231. |
Sorry, something went wrong.
Added a note that in order to enable yapf, one must disable autopep8.
Confirmed with the following config, which reports to the log which
formatter is being used when invoking
`<cmd>lua vim.lsp.buf.formatting()<CR>`
```
nvim_lsp.pylsp.setup {
cmd = { "/.../bin/pylsp", "-v", "--log-file=/tmp/pylsp.log" },
settings = {
pylsp = {
plugins = {
autopep8 = {enabled = false},
},
},
},
}
```
I only noticed this because my yapf config uses 2-space indenting
(thanks, Google, for forcing me to do this), and with no configuration
changes it will ignore that config in my `setup.cfg`, because autopep8
doesn't see it.
ccordoba12
approved these changes
Jul 2, 2022
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @j2kun for your contribution!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a note that in order to enable yapf, one must disable autopep8.
Confirmed with the following config, which reports to the log which
formatter is being used when invoking
<cmd>lua vim.lsp.buf.formatting()<CR>
nvim_lsp.pylsp.setup { cmd = { "/.../bin/pylsp", "-v", "--log-file=/tmp/pylsp.log" }, settings = { pylsp = { plugins = { autopep8 = {enabled = false}, }, }, }, }I only noticed this because my yapf config uses 2-space indenting
(thanks, Google, for forcing me to do this), and with no configuration
changes autopep8 will ignore that config in my setup.cfg and indent
with 4 spaces.