FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve schema type compliance, improve CONFIGURATION.md by krassowski · Pull Request #228 · python-lsp/python-lsp-server · GitHub

/ python-lsp-server Public

Improve schema type compliance, improve CONFIGURATION.md - #228

Merged
ccordoba12 merged 1 commit into
python-lsp:developfrom
krassowski:schema-types
Jun 29, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Improve schema type compliance, improve CONFIGURATION.md#228
ccordoba12 merged 1 commit into
python-lsp:developfrom
krassowski:schema-types

Conversation

krassowski commented Jun 24, 2022

Copy link
Copy Markdown
Member
  • Adds "item" to "array" types where missing
  • Adds "null" type where default null is used
  • Replace null with empty array ([]) where it made more sense (i.e. exclusion lists which are checked for truthiness rather than being None in the codebase)
  • Improve script generating CONFIGURATION.md:
    • support arrays of types
    • fix double whitespace instead of single whitespace when combining strings
    • fix missing enumeration of accepted values

ccordoba12 commented Jun 28, 2022

Copy link
Copy Markdown
Member

Please rebase on top of the latest develop to get the fix to our tests in PR #231.

ccordoba12 approved these changes Jun 29, 2022
View reviewed changes

ccordoba12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, thanks @krassowski!

ccordoba12 added this to the v1.5.0 milestone Jun 29, 2022
ccordoba12 merged commit 50841c1 into python-lsp:develop Jun 29, 2022
yaegassy mentioned this pull request Jun 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ccordoba12 ccordoba12 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL