Fix autoimport raising AttributeError in some cases - #309
Merged
ccordoba12 merged 3 commits intoNov 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ccordoba12
reviewed
Nov 29, 2022
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for your contribution @douo! To fix the linting error reported by Github actions, please add the following inline comment next to the definition of _should_insert:
def _should_insert(expr: tree.BaseNode, word_node: tree.Leaf) -> bool: # pylint: disable=too-many-return-statementsOtherwise looks good to me.
Sorry, something went wrong.
ccordoba12
reviewed
Nov 30, 2022
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please apply the suggestion I left below to please another of our linters.
Sorry, something went wrong.
Comment thread
test/plugins/test_autoimport.py
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
Nov 30, 2022
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks a lot for your help @douo! We really appreciate it.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detail in #307
Fixes #307