Resolve homedir references in Jedi environment path - #394
Merged
ccordoba12 merged 2 commits intoJun 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@ccordoba12 I struggled to come up with a test for it. I can use the doc fixture and go with script = doc.jedi_script()
path = script._inference_state.environment.path
assert ...But I have no idea how to inject my custom Jedi plugin configuration to that doc. It just follows my global settings. |
Sorry, something went wrong.
ccordoba12
reviewed
Jun 13, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Small suggestion, the rest looks good to me.
Also, don't worry about adding a test for this. I think it's a very simple addition that doesn't merit a test.
Sorry, something went wrong.
Comment thread
pylsp/workspace.py
Outdated
Removed debugging cruft. Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
Jun 29, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @odiroot!
Sorry, something went wrong.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 5, 2023
## Version 1.7.4 (2023/06/29) ### Issues Closed * [Issue 393](python-lsp/python-lsp-server#393) - Environment path doesn't expand user directory In this release 1 issue was closed. ### Pull Requests Merged * [PR 394](python-lsp/python-lsp-server#394) - Resolve homedir references in Jedi environment path, by [@odiroot](https://github.com/odiroot) * [PR 381](python-lsp/python-lsp-server#381) - Report progress even when initialization fails, by [@syphar](https://github.com/syphar) * [PR 380](python-lsp/python-lsp-server#380) - Fix pylint hang on file with many errors, by [@hetmankp](https://github.com/hetmankp) In this release 3 pull requests were closed.
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
## Version 1.7.4 (2023/06/29) ### Issues Closed * [Issue 393](python-lsp/python-lsp-server#393) - Environment path doesn't expand user directory In this release 1 issue was closed. ### Pull Requests Merged * [PR 394](python-lsp/python-lsp-server#394) - Resolve homedir references in Jedi environment path, by [@odiroot](https://github.com/odiroot) * [PR 381](python-lsp/python-lsp-server#381) - Report progress even when initialization fails, by [@syphar](https://github.com/syphar) * [PR 380](python-lsp/python-lsp-server#380) - Fix pylint hang on file with many errors, by [@hetmankp](https://github.com/hetmankp) In this release 3 pull requests were closed.
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
## Version 1.7.4 (2023/06/29) ### Issues Closed * [Issue 393](python-lsp/python-lsp-server#393) - Environment path doesn't expand user directory In this release 1 issue was closed. ### Pull Requests Merged * [PR 394](python-lsp/python-lsp-server#394) - Resolve homedir references in Jedi environment path, by [@odiroot](https://github.com/odiroot) * [PR 381](python-lsp/python-lsp-server#381) - Report progress even when initialization fails, by [@syphar](https://github.com/syphar) * [PR 380](python-lsp/python-lsp-server#380) - Fix pylint hang on file with many errors, by [@hetmankp](https://github.com/hetmankp) In this release 3 pull requests were closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #393
Allows easier use with virtualenvwrapper and portability of LSP configuration.