Ignore notebook names on cell completion for autoimport - #466
Merged
ccordoba12 merged 17 commits intoOct 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…completions on a cell
ccordoba12
reviewed
Oct 18, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some minor comments for you @tkrabel-db, the rest looks good to me.
Sorry, something went wrong.
Comment thread
pylsp/workspace.py
Outdated
Comment thread
test/fixtures.py
Outdated
Comment thread
test/plugins/test_autoimport.py
Outdated
Comment thread
test/test_utils.py
Outdated
Comment thread
test/test_notebook_document.py
Outdated
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review @ccordoba12 . I added all your suggestions! 🚀 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Weird, Static code analysis / Static code analysis (pull_request) failed but when looking at the details, everything passed ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Kicked, let's see if it happens again. |
Sorry, something went wrong.
ccordoba12
approved these changes
Oct 19, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me now, thanks @tkrabel-db!
Sorry, something went wrong.
staticf0x
pushed a commit
to staticf0x/python-lsp-server
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed?
With the notebook document, every cell is its own document living in the workspace. When doing rope autoimport completions on a cell document position, we should not provide completion suggestions for names already imported before that (see video below).
How is this tested?
- integration test
- manually on Databricks notebooks
Screen.Recording.2023-10-18.at.11.48.23.mov