FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add `extendSelect` option to flake8 plugin by Susensio · Pull Request #559 · python-lsp/python-lsp-server · GitHub

Add extendSelect option to flake8 plugin - #559

Merged
ccordoba12 merged 1 commit into
python-lsp:developfrom
Susensio:develop
Jul 24, 2024
Merged

Add extendSelect option to flake8 plugin#559
ccordoba12 merged 1 commit into
python-lsp:developfrom
Susensio:develop

Conversation

Copy link
Copy Markdown
Contributor

--extend-select allows adding error codes without overriding the default --select

ccordoba12 added this to the v1.12.0 milestone May 18, 2024
ccordoba12 added the enhancement New feature or request label May 18, 2024

Copy link
Copy Markdown
Member

Hey @Susensio, thanks for your contribution! It looks good to me, but there is one thing missing.

You need to run in the root of your clone the following command:

python scripts/jsonschema2md.py pylsp/config/schema.json CONFIGURATION.md

and then commit the changes that does to CONFIGURATION.md.

That's necessary because you added a new option to the server.

Copy link
Copy Markdown
Contributor Author

My bad, I didn't read the docs till the end.
I've pushed a new commit with that fixed.

ccordoba12 changed the title Add extend-select to flake8 Add extendSelect to flake8 plugin Jul 24, 2024

ccordoba12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @Susensio for your contribution!

Note: I fixed the errors reported in our Static code analysis workflow in PR #585.

ccordoba12 changed the title Add extendSelect to flake8 plugin Add extendSelect option to flake8 plugin Jul 24, 2024
ccordoba12 merged commit cf3cea1 into python-lsp:develop Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL