FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

denote 1.9.0 release by akrherz · Pull Request #159 · python-metar/python-metar · GitHub

/ python-metar Public

denote 1.9.0 release - #159

Merged
akrherz merged 1 commit into
python-metar:mainfrom
akrherz:v190
Jan 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

denote 1.9.0 release#159
akrherz merged 1 commit into
python-metar:mainfrom
akrherz:v190

Conversation

akrherz commented Dec 31, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

akrherz requested review from phobson and tomp December 31, 2021 13:56

codecov-commenter commented Dec 31, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #159 (e385d24) into main (1b832f3) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   88.43%   88.24%   -0.20%     
==========================================
  Files           4        4              
  Lines        1046     1046              
==========================================
- Hits          925      923       -2     
- Misses        121      123       +2
Impacted Files Coverage Δ
metar/__init__.py 0.00% <0.00%> (ø)
metar/Metar.py 89.74% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b832f3...e385d24. Read the comment docs.

phobson approved these changes Dec 31, 2021
View reviewed changes

phobson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm ok with this.

I remembered that on my mpl-probscale repo, I have a github workflow that publishes a new release to pypi.

https://github.com/matplotlib/mpl-probscale/blob/master/.github/workflows/python-publish.yml

Would it be worth moving that over before we do this?

akrherz commented Dec 31, 2021

Copy link
Copy Markdown
Collaborator Author

@phobson Thanks, I never object when people offer to do work :) If you are wanting me to make this magic happen, then likely not before this release.

phobson commented Dec 31, 2021

Copy link
Copy Markdown
Collaborator

@akrherz totally. I can give it a shot, Just wanted to offer it up.

Do you mind if I push a commit up to this branch that updates the python version meta data in setup.py? Currently says metar supports python >= 2.5 😭

akrherz commented Dec 31, 2021

Copy link
Copy Markdown
Collaborator Author

Do you mind if I push a commit up to this branch that updates the python version meta data in setup.py?

Sure, go for it.

akrherz commented Jan 2, 2022

Copy link
Copy Markdown
Collaborator Author

force pushed to update release date.

akrherz merged commit 5768a5c into python-metar:main Jan 3, 2022
akrherz deleted the v190 branch January 3, 2022 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

phobson phobson approved these changes
tomp Awaiting requested review from tomp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL