FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typing - 'test_basic.py', 'base.py', 'column.py', 'test_abnormal.py', 'benchmark.py' by soulee-dev · Pull Request #82 · python-mysql-replication-kr/python-mysql-replication · GitHub

/ python-mysql-replication Public
forked from julien-duponchelle/python-mysql-replication

typing - 'test_basic.py', 'base.py', 'column.py', 'test_abnormal.py', 'benchmark.py' - #82

Open
soulee-dev wants to merge 16 commits into
mainfrom
enhancement/typing-group-1
ConversationCommits (16)ChecksFiles changed
Open

typing - 'test_basic.py', 'base.py', 'column.py', 'test_abnormal.py', 'benchmark.py'#82
soulee-dev wants to merge 16 commits into
mainfrom
enhancement/typing-group-1

Conversation

soulee-dev commented Aug 31, 2023

Copy link
Copy Markdown

No description provided.

soulee-dev commented Aug 31, 2023

Copy link
Copy Markdown
Author

현재 문제가 발생하는 테스트 수정 해놓겠습니다

soulee-dev commented Aug 31, 2023

Copy link
Copy Markdown
Author
  • mypy로 한번 테스트 돌려보고, 몇가지 타입 힌트 추가
mypy pymysqlreplication/tests/ --check-untyped-defs --allow-redefinition
  • 작동하지 않는 테스트 수정

파일당 하나의 커밋으로 squash 진행 하겠습니다

soulee-dev added the 1조 1조 이슈 label Sep 1, 2023
dongwook-chan approved these changes Sep 1, 2023
View reviewed changes

dongwook-chan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

꼼꼼하게 typing 적용 잘 해주셨습니다! 다들 고생 많으셨어요!! 👍🏻👍🏻👍🏻

soulee-dev commented Sep 2, 2023

Copy link
Copy Markdown
Author

feat : mirageoasis typing complete > test_basic.py
Add type annotations to test_abnormal.py > test_abnormal.py
Add type annotations to column.py > column.py
Add type annotations to benchmark.py > benchmark.py
add: type hint for test_basic.py > test_basic.py
fix: return value for test_drop_column > test_basic.py
Add type annotations to base.py > base.py
Fix formatting to base.py > base.py
fix: remove unused imports > test_basic.py
fix: import pymysql.cursors always > base.py
add: type hints for PyMyReplTestCase > base.py
add: type hints for connections > benchmark.py
add: type hints for stream > test_abnormal.py
fix: wrong type hint for Gtid > test_basic.py
fix: add bytes to query string > test_basic.py

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dongwook-chan dongwook-chan approved these changes

Assignees

soulee-dev

mirageoasis

wonkajin

davinc71998

Labels

1조 1조 이슈

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL