feat: handle allof when required linked to parent object (#97) - #154
Merged
p1c2u merged 1 commit intoJun 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 96.37% 96.42% +0.04%
==========================================
Files 19 19
Lines 552 559 +7
Branches 104 105 +1
==========================================
+ Hits 532 539 +7
Misses 10 10
Partials 10 10
Continue to review full report at Codecov.
|
Sorry, something went wrong.
p1c2u
approved these changes
Jun 17, 2022
p1c2u
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@hibougeek thank you for the contribution |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some code to handle allof case with required set at the parent object level (a bit different than the case originally done in #97 ).