FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: check duplicates schemas when loading swagger by Marwen94 · Pull Request #157 · python-openapi/openapi-spec-validator · GitHub

/ openapi-spec-validator Public

fix: check duplicates schemas when loading swagger - #157

Open
Marwen94 wants to merge 1 commit into
python-openapi:masterfrom
Marwen94:check_duplicates_schemas_defs_when_loading_swagger
ConversationCommits (1)ChecksFiles changed
Open

fix: check duplicates schemas when loading swagger#157
Marwen94 wants to merge 1 commit into
python-openapi:masterfrom
Marwen94:check_duplicates_schemas_defs_when_loading_swagger

Conversation

Marwen94 commented Jun 22, 2022

Copy link
Copy Markdown

Closes #156

codecov Bot commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #157 (45dd535) into master (a29b4f9) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   95.97%   96.09%   +0.12%     
==========================================
  Files          18       18              
  Lines         547      564      +17     
  Branches      103      109       +6     
==========================================
+ Hits          525      542      +17     
  Misses         12       12              
  Partials       10       10
Impacted Files Coverage Δ
openapi_spec_validator/handlers/compat.py 90.90% <100.00%> (+30.90%) ⬆️
openapi_spec_validator/handlers/file.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29b4f9...45dd535. Read the comment docs.

Marwen94 commented Jun 29, 2022

Copy link
Copy Markdown
Author

@p1c2u could you please have a look at this PR ?

p1c2u commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

Looks good. Just wondering how this affects the performance.

Marwen94 commented Jun 30, 2022

Copy link
Copy Markdown
Author

Looks good. Just wondering how this affects the performance.

I don't think this influences a lot the performance since it only adds an o(n) complexity where n is the number of schema in a given swagger. Imho n in a real world context is in [1, 100].

We can set the duplicate check optional also, what do you think ?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicates schemas definitions are not validated

2 participants

Back | FazBrowse Home | New Git URL