fix: accept fractional w:pgMar twips values in ST_TwipsMeasure - #1552
Open
SAY-5 wants to merge 1 commit into
Open
fix: accept fractional w:pgMar twips values in ST_TwipsMeasure#1552SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Gentle ping on this. Word docs in the wild do write fractional twips in w:pgMar (LibreOffice does it), and python-docx currently raises on them, so this just rounds instead of rejecting. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Word documents store w:pgMar attributes like w:right="0.218505859375", which currently raises ValueError from int() when reading section.right_margin. This mirrors the rounding already done by ST_SignedTwipsMeasure so unsigned twips measures tolerate the same fractional values. Closes #1539