Fix subtracting negative timedelta around DST - #419
Merged
sdispater merged 1 commit intoJul 4, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for your contribution! Can you rebase your PR on master? |
Sorry, something went wrong.
tomage
force-pushed
the
fix-subtracting-negative-timedelta-around-dst
branch
from
15ded3f to
9751130
Compare
March 8, 2020 02:31
Copy link
Copy Markdown
Contributor
Author
|
Sure thing! Just rebased on top of latest master from you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for your contribution! |
Sorry, something went wrong.
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that in a very specific case, subtracting a negative timedelta yielded different results than adding the same positive timedelta.
I.e. my_dt + timedelta(hours=10) ~= my_dt - timedelta(hours=-10).
Digging into the git log, I found that a similar fix was done for the positive case here: 1ec1ad0.
It seemed logical/symmetrical to do similar with the negative case, although there may have been some good reasons for why _add_timedelta() is different from _subtract_timedelta() that I'm missing.
I also threw in one test case to test specifically subtracting a negative timedelta.
Looking forward to your feedback as always.