FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: `pendulum.parse` is not marked as exported by cosmix · Pull Request #693 · python-pendulum/pendulum · GitHub

/ pendulum Public

fix: pendulum.parse is not marked as exported - #693

Merged
Secrus merged 1 commit into
python-pendulum:masterfrom
cosmix:master
Apr 24, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: pendulum.parse is not marked as exported#693
Secrus merged 1 commit into
python-pendulum:masterfrom
cosmix:master

Conversation

cosmix commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

This PR fixes #595, by re-exporting parse().

parse() should be re-exported so that the user can just call pendulum.parse() as documented, given that the module is marked with py.typed.

No tests have been modified or added for this bugfix.

cosmix commented Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

Note that the failing CI test has to do with the fact that the flake8 module that you're using seems to not like the import aliasing that needs to be used to fix the issue addressed by this PR and that exports the parse symbol in __init__.py.

For reference, I'm using the type checker rules listed on the pyright README here, but, to my understanding these are rules common to more type checkers for Python.

Secrus commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Hi. Sorry for the delays, we are digging ourselves out of the pile of code debt. Could you please rebase your changes with the master branch so we can review and merge them?

Secrus added this to the Pendulum 3.2 milestone Apr 23, 2025
Secrus changed the title fixup: Fix #595 fix: pendulum.parse is not marked as exported Apr 23, 2025

cosmix commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@Secrus done.

codspeed-hq Bot commented Apr 24, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #693 will not alter performance

Comparing cosmix:master (7ef1b0b) with master (91d0c1e)

Summary

✅ 1 untouched benchmarks

Secrus merged commit 1034b18 into python-pendulum:master Apr 24, 2025
Secrus mentioned this pull request Jan 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Secrus Secrus approved these changes
+1 more reviewer
navmed navmed approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Pendulum 3.3

Development

Successfully merging this pull request may close these issues.

pendulum.parse is not marked as exported (pyright type checker in VSCode)

3 participants

Back | FazBrowse Home | New Git URL