Fix pendulum.tz.timezones() to use system tzdata - #801
Conversation
Sorry, something went wrong.
|
Gentle ping. |
Sorry, something went wrong.
I can. But since you've already merged master into it, could you confirm that you still want me to rebase? |
Sorry, something went wrong.
|
Hey @mgorny sorry for the delays and merge/rebase mess. I would appreciate a rebase (I won't interfere this time 🙈). |
Sorry, something went wrong.
Fix the `pendulum.tz.available_timezones()` to use `available_timezones()` function instead of iterating over the files in `tzdata` package. This is more in line with PEP 615, as the system timezone functions will operate on system-provided tzdata when available, and use the `tzdata` package only if it's not available. Therefore, the previous code would yield a potentially different list of timezones than the system actually provides. Furthermore, Gentoo provides a dummy `tzdata` package that does not provide any data, since Python always uses system tzdata. This change is necessary to make pendulum work again on Gentoo. Fixes python-pendulum#769
CodSpeed Performance ReportMerging #801 will not alter performanceComparing mgorny:system-tzdata (02890eb) with master (6705906) Summary✅ 1 untouched benchmarks |
Sorry, something went wrong.
|
Rebased, fixed typing and ruff lints, implemented suggestions from @dvzrv. |
Sorry, something went wrong.
Secrus
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for your work!
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
Fix the pendulum.tz.available_timezones() to use available_timezones() function instead of iterating over the files in tzdata package. This is more in line with PEP 615, as the system timezone functions will operate on system-provided tzdata when available, and use the tzdata package only if it's not available. Therefore, the previous code would yield a potentially different list of timezones than the system actually provides.
Furthermore, Gentoo provides a dummy tzdata package that does not provide any data, since Python always uses system tzdata. This change is necessary to make pendulum work again on Gentoo.
Fixes #769
Pull Request Check List