Pluralization bug with Duration.in_words() - #826
Merged
ashb merged 7 commits intoJul 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
VascoSch92
reviewed
May 20, 2024
Comment thread
src/pendulum/duration.py
Outdated
Co-authored-by: Vasco Schiavo <115561717+VascoSch92@users.noreply.github.com>
ashb
reviewed
Jul 16, 2025
ashb
reviewed
Jul 16, 2025
Comment thread
src/pendulum/duration.py
Outdated
ashb
reviewed
Jul 16, 2025
Separating out fix from adding seoncds_n_decimal
Copy link
Copy Markdown
CodSpeed Performance ReportMerging #826 will not alter performanceComparing Solipsistmonkey:master (f454f09) with master (b45e22d) Summary✅ 1 untouched benchmarks |
Sorry, something went wrong.
ashb
reviewed
Jul 16, 2025
Comment thread
src/pendulum/duration.py
Outdated
Comment thread
src/pendulum/duration.py
Outdated
Comment thread
tests/duration/test_in_words.py
Outdated
ashb
reviewed
Jul 16, 2025
Comment thread
src/pendulum/duration.py
Outdated
ashb
reviewed
Jul 17, 2025
Comment thread
src/pendulum/duration.py
Outdated
ashb
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that Duration(milliseconds=10).in_words() would return 0.01 second when it should be 0.01 seconds. So I fixed that but also realized that sometimes people might want a bit more precision so I added a keyword arg seconds_n_digits with a default value of 2.