FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix parsing invalid intervals by wiget · Pull Request #843 · python-pendulum/pendulum · GitHub

/ pendulum Public

Fix parsing invalid intervals - #843

Merged
Secrus merged 2 commits into
python-pendulum:masterfrom
wiget:single-slash
Dec 4, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix parsing invalid intervals#843
Secrus merged 2 commits into
python-pendulum:masterfrom
wiget:single-slash

Conversation

wiget commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

Parsing a string with a slash at the start or the end raised IndexError instead of ParseError.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

wiget commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

@sdispater would you mind reviewing this PR?

codspeed-hq Bot commented Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #843 will not alter performance

Comparing wiget:single-slash (ae719c6) with master (b84b976)

Summary

✅ 1 untouched benchmarks

Secrus reviewed Sep 22, 2024
View reviewed changes
Comment thread src/pendulum/parsing/__init__.py Outdated

johnslavik commented Sep 22, 2024

Copy link
Copy Markdown

If I could suggest something, it would be just using [:1] instead of [0:1], as the former simply works and is less unnecessarily explicit.

Similarly to how you would probably prefer reading range(10) than range(0, 10).

wiget commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

@bswck You are right. Suggestion applied.

wiget requested review from Secrus and johnslavik September 23, 2024 12:36
wiget mentioned this pull request Oct 10, 2024
Closed

wiget commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@Secrus would you mind reviewing this PR?

temporaer mentioned this pull request Oct 28, 2024
Closed

wiget commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review.

What is required to get this PR merged?

Secrus commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

@wiget please rebase your branch with master so the pipelines run. Right now it looks like GH has some issues here.

wiget added 2 commits November 21, 2024 14:27
Fix parsing invalid intervals
d9a6917 
Parsing string with slash at the start or the end raised IndexError
instead of ParseError.
Apply suggestion from review
ae719c6

wiget commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

All checks passed. Would you mind merging this PR, @Secrus ?

Secrus merged commit 6205754 into python-pendulum:master Dec 4, 2024

bennetrr commented Dec 5, 2024

Copy link
Copy Markdown

Is there a release planned for this?

wiget deleted the single-slash branch December 5, 2024 21:58
saengowp mentioned this pull request Feb 24, 2025
Open
Secrus mentioned this pull request Apr 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Secrus Secrus approved these changes
+1 more reviewer
johnslavik johnslavik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL