FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify and unify UNIX timezone retrival by Secrus · Pull Request #938 · python-pendulum/pendulum · GitHub

Simplify and unify UNIX timezone retrival - #938

Open
Secrus wants to merge 1 commit into
python-pendulum:masterfrom
Secrus:unix-timezone
Open

Simplify and unify UNIX timezone retrival#938
Secrus wants to merge 1 commit into
python-pendulum:masterfrom
Secrus:unix-timezone

Conversation

Secrus commented Jan 30, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Closes: #837
Closes: #840
Closes: #829

Secrus requested a review from ashb January 30, 2026 14:29

codspeed-hq Bot commented Jan 30, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing Secrus:unix-timezone (150aa01) with master (aea611d)

Summary

✅ 1 untouched benchmark

Secrus commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

mgorny commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

If you're asking whether tests pass after this change on my system, they do. They also pass if I remove /etc/localtime altogether or copy the specific timezone there. I think that's all the scenarios we "support".

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

CC @hroncok (sorry, don't recall anyone else offhand, though I really should have)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants


Back | FazBrowse Home | New Git URL