Make Ukrainian locale name follow ISO 639, update it and add tests - #957
Merged
Secrus merged 4 commits intoAug 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 1 untouched benchmark Comparing nykula:master (fd45ad8) with master (cbab60c) |
Sorry, something went wrong.
afastronomer
reviewed
Apr 8, 2026
Comment thread
tests/localization/test_uk.py
ashb
previously requested changes
Apr 8, 2026
Comment thread
src/pendulum/locales/uk/locale.py
afastronomer
reviewed
Apr 8, 2026
Comment thread
tests/localization/test_uk.py
afastronomer
reviewed
Apr 8, 2026
Comment thread
tests/localization/test_uk.py
Secrus
reviewed
Apr 10, 2026
Comment thread
src/pendulum/locales/locale.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
My bad, left the updated test file uncommitted. |
Sorry, something went wrong.
Secrus
approved these changes
Aug 20, 2026
Secrus
enabled auto-merge (squash)
August 20, 2026 13:02
Secrus
disabled auto-merge
August 20, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Fixes #955.