fix: preserve microsecond precision in Duration for large values - #969
Open
SAY-5 wants to merge 1 commit into
Open
fix: preserve microsecond precision in Duration for large values#969SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Fixes #332.
Duration derived its normalized microseconds/seconds/days fields from total_seconds(), which returns a float and loses precision for large values:
The normalization now works on exact integer microseconds taken from the parent timedelta fields, matching datetime.timedelta behavior. The same float-precision issue in AbsoluteDuration (used by Time.diff()) is fixed the same way.
No documentation change needed; this restores the documented microseconds semantics.