FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replaced absolute PIL imports with relative imports by radarhere · Pull Request #2349 · python-pillow/Pillow · GitHub

Replaced absolute PIL imports with relative imports - #2349

Merged
wiredfool merged 2 commits into
python-pillow:masterfrom
radarhere:relative
Jan 17, 2017
Merged

Replaced absolute PIL imports with relative imports#2349
wiredfool merged 2 commits into
python-pillow:masterfrom
radarhere:relative

Conversation

Copy link
Copy Markdown
Member

Resolves #2342

The following files cannot use relative imports because they may be run directly, as shown by their if __name__ == "__main__": line -

  • IcnsImagePlugin
  • ImageCms
  • ImageShow
  • SpiderImagePlugin

Copy link
Copy Markdown
Member Author

This makes me think about the usefulness of a 'It's fine, it's fine, the coverage only dropped because there's fewer lines' label.

Copy link
Copy Markdown
Member

Coveralls is only approximately useful, as there are often 'changes' in coverage to unrelated files.

Perhaps a better label would be 'It's fine, coveralls is drunk. Again.'

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL