FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Python 3.7 and Xenial to Travis CI by hugovk · Pull Request #3234 · python-pillow/Pillow · GitHub

/ Pillow Public

Add Python 3.7 and Xenial to Travis CI - #3234

Merged
hugovk merged 3 commits into
python-pillow:masterfrom
hugovk:xenial-ci
Aug 23, 2018
ConversationCommits (3)ChecksFiles changed
Merged

Add Python 3.7 and Xenial to Travis CI#3234
hugovk merged 3 commits into
python-pillow:masterfrom
hugovk:xenial-ci

Conversation

hugovk commented Jul 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

The main thing here is adding Python 3.7 (and removing 3.7-dev), which requires Xenial.

Whilst we're at it, we can test most Python versions on both Trusty and Xenial.

If we don't want all, we should probably do at least a few on both.

Changes proposed in this pull request:

Python 14.04 Trusty 16.04 Xenial
PyPy2 yes no
PyPy3 yes no
3.7 no yes
3.6 yes yes
3.5 yes yes
3.4 yes no
2.7 yes yes

hugovk added the Build label Jul 5, 2018
radarhere reviewed Jul 21, 2018
View reviewed changes
Comment thread .travis.yml
- python: '3.5'
dist: trusty
- python: '3.4'
dist: trusty

radarhere Jul 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You've missed 3.4 on Xenial.

radarhere Jul 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nevermind, I see now.

hugovk Jul 21, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

PyPy2/3 and 3.4 only support Trusty on Travis.

Here's how they look: https://travis-ci.org/hugovk/Pillow/builds/397828420

hugovk commented Aug 17, 2018

Copy link
Copy Markdown
Member Author

Any comments on this? If not, I'll merge it next week.

It adds 4 new jobs to the build, increasing build time from ~16m to ~22m.

Trusty 14.04 goes EOL in 2019-04 and Python 3.4 goes EOL on 2019-03-16, so we can remove 4-6 jobs relatively soon, and should start testing on Xenial 16.04.

(Hopefully by then PyPy/3 will be available on something newer, otherwise we could keep those on Trusty a bit longer.)

hugovk merged commit 693e161 into python-pillow:master Aug 23, 2018
hugovk deleted the xenial-ci branch August 23, 2018 12:20
hugovk mentioned this pull request Oct 11, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

radarhere radarhere left review comments

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL