FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add docs for features module by nulano · Pull Request #4688 · python-pillow/Pillow · GitHub

/ Pillow Public

Add docs for features module - #4688

Merged
hugovk merged 2 commits into
python-pillow:masterfrom
nulano:featers-docs
Jun 15, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Add docs for features module#4688
hugovk merged 2 commits into
python-pillow:masterfrom
nulano:featers-docs

Conversation

nulano commented Jun 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds documentation for the features module. The only other reference to it before was in the 5.4.0 release docs.

nulano commented Jun 13, 2020
View reviewed changes
Comment thread docs/reference/ImageGrab.rst
.. versionadded:: 1.1.3

.. py:function:: PIL.ImageGrab.grab(bbox=None, include_layered_windows=False, all_screens=False, xdisplay=None)
.. py:function:: grab(bbox=None, include_layered_windows=False, all_screens=False, xdisplay=None)

nulano Jun 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change is necessary to fix links. It also fixes the source button in the docs.

hugovk reviewed Jun 13, 2020
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some little nits

Comment thread docs/reference/features.rst Outdated
Comment thread docs/reference/features.rst Outdated
Comment thread docs/reference/features.rst Outdated
Comment thread docs/reference/features.rst Outdated

* ``jpg``: (compile time) LibJpeg support, required for JPEG based image formats.
* ``jpg_2000``: (compile time) OpenJpeg support, required for JPEG 2000 image formats.
* ``zlib``: (compile time) ZLib support, required for ZLib compressed formats, such as PNG.

hugovk Jun 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
* ``zlib``: (compile time) ZLib support, required for ZLib compressed formats, such as PNG.
* ``zlib``: (compile time) zlib support, required for zlib compressed formats, such as PNG.

nulano Jun 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I went with "Zlib" for the first one, as it is the start of a sentence.

Comment thread docs/reference/features.rst Outdated
Comment thread src/PIL/features.py Outdated
Comment thread src/PIL/features.py Outdated
Comment thread src/PIL/features.py Outdated
Comment thread src/PIL/features.py Outdated
Comment thread src/PIL/features.py Outdated
radarhere reviewed Jun 13, 2020
View reviewed changes
Comment thread src/PIL/features.py Outdated
formatting improvements
d05a08a 
Co-authored-by: Hugo <hugovk@users.noreply.github.com>

nulano commented Jun 14, 2020

Copy link
Copy Markdown
Contributor Author

I would also like to propose adding a public API for checking library versions and including version numbers in pilinfo. Should I add it here or open a new PR (that depends on this PR due to docs)?

hugovk commented Jun 15, 2020

Copy link
Copy Markdown
Member

Let's merge this and you can open a new PR.

Thanks!

hugovk merged commit d6be133 into python-pillow:master Jun 15, 2020
nulano mentioned this pull request Jun 15, 2020
Merged
nulano deleted the featers-docs branch June 27, 2020 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
radarhere radarhere left review comments

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL