FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for CBDT and COLR fonts by nulano · Pull Request #4955 · python-pillow/Pillow · GitHub

/ Pillow Public

Add support for CBDT and COLR fonts - #4955

Merged
hugovk merged 13 commits into
python-pillow:masterfrom
nulano:ft-color3
Oct 12, 2020
ConversationCommits (13)ChecksFiles changed
Merged

Add support for CBDT and COLR fonts#4955
hugovk merged 13 commits into
python-pillow:masterfrom
nulano:ft-color3

Conversation

nulano commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proper fix for #891, partial support for #3346

Changes proposed in this pull request:

  • properly detect glyph bitmap mode instead of guessing
  • use FT_Convert_Bitmap instead of a custom solution
  • add support for Google CBDT (if FreeType is compiled with libpng) and Microsoft COLR fonts

Apple SBIX and W3C SVG fonts are not yet supported by FreeType.

Example:

from PIL import Image, ImageDraw, ImageFont

def test(font, out_name):
    fnt = ImageFont.truetype(font, size=109, layout_engine=ImageFont.LAYOUT_RAQM)
    im = Image.new("RGBA", (600, 600), (100, 100, 100, 100))
    draw = ImageDraw.Draw(im)
    draw.text((0, 32), "a\u263A", fill="#faa2", embedded_color=True, font=fnt)
    draw.text((0, 132), "a\u263A", fill="#faa8", embedded_color=True, font=fnt)
    draw.text((0, 232), "a\u263A", fill="#faa", embedded_color=True, font=fnt)
    draw.text((0, 332), "\U0001F3AC\U0001F44B\U0001F3FB\U0001F44B\U0001F3FF", fill="white", embedded_color=True, font=fnt)
    draw.text((0, 432), "a\u263A", fill="#faa2", font=fnt)
    im.show()
    im.save(f"testemoji_{out_name}.png")

test(r"C:\Users\Nulano\Downloads\NotoColorEmoji.ttf", "cbdt")
test("seguiemj.ttf", "colr")

NotoColorEmoji.ttf (CBDT):

seguiemj.ttf (COLR):

nulano commented Oct 7, 2020
View reviewed changes
Comment thread Tests/test_imagefont_bitmap.py Outdated

nulano commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

Big-endian s390 is failing, but I'm not sure I can fix it without seeing the output image.

hugovk commented Oct 7, 2020

Copy link
Copy Markdown
Member

This increases the size of the sdist by about 20% from 58M to 69M.

Are all these fonts necessary, or can we still be confident in testing with existing fonts (I guess they're not CBDT or COLR), or just one of the smaller additions?

nulano commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This increases the size of the sdist by about 20% from 58M to 69M.

Are all these fonts necessary, or can we still be confident in testing with existing fonts (I guess they're not CBDT or COLR), or just one of the smaller additions?

DejaVuSans-24-*.ttf (6MB total) can be replaced by a different font or a cut-down version with just a few glyphs for testing.
Edit: replaced by stripped down versions (keeping ASCII range only) with ~60KB each.

The biggest chunk is the 9MB CBDT font NotoColorEmoji.ttf; CBDT fonts are essentially just a collection of bitmaps (uncompressed or PNG), so any font will be large. If the license allows it, stripping out all except the tested bitmaps might be possible.
Edit: FontForge can't open it so I'm not sure how I would strip it down. It might be easier to recompile it from source keeping only the one glyph that is tested.

BungeeColor-Regular_colr_Windows.ttf (COLR font) is just 73.6 KB.

radarhere commented Oct 7, 2020

Copy link
Copy Markdown
Member

Big-endian s390 is failing, but I'm not sure I can fix it without seeing the output image.

Here you go - generated with this commit forked from your branch.

nulano commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

Big-endian s390 is failing, but I'm not sure I can fix it without seeing the output image.

Here you go - generated with this commit forked from your branch.

Ah, I had the right idea, but forgot long long is 8 bytes...

Thanks for the help.

nulano commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

This increases the size of the sdist by about 20% from 58M to 69M.

Are all these fonts necessary, or can we still be confident in testing with existing fonts (I guess they're not CBDT or COLR), or just one of the smaller additions?

I've stripped down the DejaVuSans-24-*.ttf fonts to ASCII and used an older version of NotoColorEmoji.ttf (5.1MB). Is this sufficient?
I can't find any other CBDT fonts or a simple way to edit them.

luiz-meireles mentioned this pull request Oct 9, 2020
Open

hugovk commented Oct 11, 2020

Copy link
Copy Markdown
Member

Looks like we also need the setuptools workaround for 3.8 (like #4958) for Windows/GHA:

RuntimeWarning: The _imaging extension was built for another version of Pillow or PIL:
Core version: None
Pillow version: 8.0.0.dev0
Traceback (most recent call last):
  File "selftest.py", line 6, in <module>
    from PIL import Image, features
  File "<frozen zipimport>", line 259, in load_module
  File "C:\hostedtoolcache\windows\Python\3.8.6\x86\lib\site-packages\pillow-8.0.0.dev0-py3.8-win32.egg\PIL\Image.py", line 97, in <module>
ImportError: The _imaging extension was built for another version of Pillow or PIL:
Core version: None
Pillow version: 8.0.0.dev0
Error: Process completed with exit code 1.

https://github.com/python-pillow/Pillow/pull/4955/checks?check_run_id=1239105264

nulano commented Oct 11, 2020

Copy link
Copy Markdown
Contributor Author

#4958 already includes 3.8, this branch just needs to be rebased or merge master (I think re-running the checks should suffice)

hugovk approved these changes Oct 11, 2020
View reviewed changes
Comment thread Tests/test_imagefont.py Outdated
Comment thread Tests/test_imagefont.py Outdated
Comment thread Tests/test_imagefont.py Outdated
Comment thread Tests/test_imagefont.py Outdated
if parse_version(features.version_module("freetype2")) < parse_version(
"2.10.0"
):
pytest.skip("Freetype 2.10.0 or newer required")

hugovk Oct 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's quite a few Freetype version check and skips, let's put them into a helper, for example:

def skip_unless_freetype(required_version, message):

nulano Oct 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I went with the following to let the check be reusable for other features:

def skip_unless_feature_version(feature, version_required, reason=None):

Comment thread Tests/test_imagefont_bitmap.py Outdated
Comment thread docs/reference/ImageDraw.rst Outdated

nulano commented Oct 11, 2020

Copy link
Copy Markdown
Contributor Author

Removing test_imagefont_bitmap.test_similar (in favor of the new test test_imagefont.test_bitmap_font) also allows removing 0.9MB DejaVuSans-bitmap.ttf.

nulano mentioned this pull request Oct 12, 2020
Merged
nulano mentioned this pull request Oct 12, 2020
Merged
hugovk merged commit 43c3f4d into python-pillow:master Oct 12, 2020

hugovk commented Oct 12, 2020

Copy link
Copy Markdown
Member

Thank you! Please can you add release notes for this, plus for any of your other PRs since the last release?

hugovk mentioned this pull request Oct 12, 2020
Closed
24 tasks
nulano mentioned this pull request Oct 12, 2020
Merged
nulano deleted the ft-color3 branch October 14, 2020 19:01
nulano mentioned this pull request Oct 20, 2020
Merged
nulano mentioned this pull request Dec 9, 2020
Closed
nulano mentioned this pull request Dec 30, 2020
Merged
radarhere mentioned this pull request Jan 21, 2021
Closed
NightMachinery mentioned this pull request Mar 14, 2021
Closed

NightMachinery commented Mar 14, 2021

Copy link
Copy Markdown

Apple font is fine on my system, FYI.

Is there a way to use one font for emojis and another for the normal text?

nulano commented Mar 14, 2021

Copy link
Copy Markdown
Contributor Author

Apple font is fine on my system, FYI.

Yep, figured that out a few weeks after this PR (#5155).

Is there a way to use one font for emojis and another for the normal text?

Not automatically, see #4808. If you are fine with splitting up the text yourself, you can use the approach outlined here: #3346 (comment).

mrsrmn mentioned this pull request Aug 13, 2021
Open
jdhao mentioned this pull request Apr 1, 2022
Closed
This was referenced Jan 1, 2023
Merged
Merged
radarhere mentioned this pull request Aug 2, 2023
Closed
nulano mentioned this pull request Nov 7, 2023
Merged
nulano mentioned this pull request Mar 12, 2024
Closed
raldone01 mentioned this pull request Nov 11, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

Font Rendering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL