Speed improvement. Rather than grabbing the complete screen on macOS, and then cropping the result to the bbox requested by the user, this PR tells screencapture the co-ordinates that we are interested in. The image does need to be resized afterwards, to avoid returning a image twice the size of the requested bbox, but presumably that is still faster than loading an image the size of the screen and cropping it.
Since screencapture without arguments returns an image at double resolution, cropping to the bbox can produce an unexpected offset. By passing the arguments to screencapture, Pillow can leave the problem of calculating which portion of the screen is desired to the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6144
There are two ways of looking at this change.