FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add JPEG XL Open/Read support via libjxl by olokelo · Pull Request #7848 · python-pillow/Pillow · GitHub

/ Pillow Public

Add JPEG XL Open/Read support via libjxl - #7848

Open
olokelo wants to merge 96 commits into
python-pillow:mainfrom
olokelo:jxl-support2
ConversationCommits (96)ChecksFiles changed
Open

Add JPEG XL Open/Read support via libjxl#7848
olokelo wants to merge 96 commits into
python-pillow:mainfrom
olokelo:jxl-support2

Conversation

olokelo commented Mar 2, 2024 •
edited by radarhere
Loading

Copy link
Copy Markdown

Helps #4247

This PR enables opening and reading JPEG XL images and animations.
Supported image modes are: RGB, RGBA, RGBa, L, LA, La.
A relatively recent libjxl version is needed to compile Pillow with libjxl support.
The main changes are the addition of _jxl.c and JxlImagePlugin.py.
I'm also the author of jxlpy so this PR was influenced by the work of contributors there. This PR is also largely based on WebPImagePlugin.py which had similar implementation.

Why?
JPEG XL has recently seen increased adoption especially in Apple ecosystem. A lot of users are requesting Pillow support for JPEG XL as their products use Pillow and need to be able to handle jxl files.

I'm open to suggestions and comments. I understand such change would need a lot of testing and probably changes. After all Pillow would need to become somewhat dependent on libjxl. Creating documentation will not be a big problem however I decided to wait for feedback from Pillow core developers.

radarhere reviewed Mar 2, 2024
View reviewed changes
Comment thread src/PIL/features.py Outdated
radarhere reviewed Mar 2, 2024
View reviewed changes
Comment thread Tests/test_jxl_leaks.py Outdated
radarhere reviewed Mar 2, 2024
View reviewed changes
Comment thread Tests/test_file_jxl_metadata.py Outdated
radarhere reviewed Mar 2, 2024
View reviewed changes
Comment thread src/PIL/JxlImagePlugin.py Outdated
olokelo mentioned this pull request Mar 2, 2024
Open

brunoais commented Mar 2, 2024 •
edited
Loading

Copy link
Copy Markdown

May you please commit the images as LFS?

olokelo commented Mar 2, 2024 •
edited by radarhere
Loading

Copy link
Copy Markdown
Author

Do you mean those .jxl files under Tests/images I've committed? I'm not really sure how to do that.

brunoais commented Mar 3, 2024

Copy link
Copy Markdown

The explanation is outlined here: https://docs.github.com/en/repositories/working-with-files/managing-large-files/configuring-git-large-file-storage
Nevermind. I just noticed they are not putting the test images as lfs:

They already setup lfs and they only use for other larger stuff. Let it stay as you did.

radarhere mentioned this pull request Mar 6, 2024
Merged
radarhere added the JPEG label Mar 11, 2024

olokelo commented Mar 11, 2024

Copy link
Copy Markdown
Author

Mac OS builds were failing because clang complained about goto labels being declared before variables in scope.
I also merged @radarhere's commits that remove the jxl feature which was causing troubles before.
Now it should be fine. Almost all checks pass except codecov.

radarhere reviewed Mar 19, 2024
View reviewed changes
Comment thread src/PIL/JxlImagePlugin.py Outdated
hugovk reviewed Mar 19, 2024
View reviewed changes
Comment thread src/PIL/__init__.py Outdated
Comment thread Tests/test_file_jxl_metadata.py
Comment thread Tests/test_jxl_leaks.py Outdated
Comment thread Tests/test_jxl_leaks.py Outdated
Comment thread Tests/test_jxl_leaks.py Outdated
Comment thread src/_jxl.c
Comment thread src/PIL/JxlImagePlugin.py Outdated
Comment thread src/PIL/JxlImagePlugin.py Outdated
Comment thread src/PIL/JxlImagePlugin.py Outdated
Comment thread src/PIL/JxlImagePlugin.py

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view
hugovk reviewed Mar 19, 2024
View reviewed changes
Comment thread src/PIL/JxlImagePlugin.py Outdated
Comment thread src/PIL/JxlImagePlugin.py

hugovk commented Jan 2, 2026

Copy link
Copy Markdown
Member

How much bigger does this make the wheels?

We need to keep in mind increased wheel size effects everyone, even if they don't use JXL (not the case with opt-in plugins).

When we added AVIF, we initially had problems with the wheels being too big: #8856

radarhere commented Jan 2, 2026

Copy link
Copy Markdown
Member

It does increase the size significantly. The current total size of our wheels is 531.5mb. In this PR, it is 730.2mb.

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view
Stormheg mentioned this pull request Feb 25, 2026
Open
radarhere force-pushed the jxl-support2 branch 2 times, most recently from b266143 to 902929f Compare April 24, 2026 05:50

hugovk commented Apr 26, 2026

Copy link
Copy Markdown
Member

It does increase the size significantly. The current total size of our wheels is 531.5mb. In this PR, it is 730.2mb.

This seems like too much. I know we have fewer wheels right now, but it will soon increase for 3.15+3.15t, and a ~37% increase is a lot. And it will be paid by everyone, including those not using JPEG XL.

I think we should consider some of the suggestions I made at #9101 (comment).

h-vetinari commented Apr 26, 2026

Copy link
Copy Markdown

I think we should consider some of the suggestions I made at #9101 (comment).

I think that's a very worthwhile initiative, though IMO that should be pursued independently; IOW, I wouldn't like to see jpegxl support held up over this.

aclark4life commented Apr 26, 2026

Copy link
Copy Markdown
Member

I think that's a very worthwhile initiative, though IMO that should be pursued independently; IOW, I wouldn't like to see jpegxl support held up over this.

We can try to decide on and implement some alternative to "including in the wheel" prior to the next release.

hugovk commented Apr 27, 2026

Copy link
Copy Markdown
Member

I think that's a very worthwhile initiative, though IMO that should be pursued independently; IOW, I wouldn't like to see jpegxl support held up over this.

The thing is, the current size increase is a blocker for me.

hugovk mentioned this pull request May 8, 2026
Merged

hugovk commented May 13, 2026

Copy link
Copy Markdown
Member

We've added some tooling (#9621) to show the size increase of wheels compared to the last release.

This PR makes the total wheel size 46.83% bigger, with some individual wheels 89% bigger.

Dist size comparison vs Pillow 12.2.0 on PyPI

File Size before Size now Change
sdist (.tar.gz) 47.0 MB 47.4 MB 🟡 +0.90%
cp310-cp310-macosx_10_10_x86_64.whl 5.4 MB 10.1 MB 🔴 +89.01%
cp310-cp310-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.67%
cp310-cp310-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp310-cp310-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp310-cp310-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.6 MB 🔴 +51.13%
cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.83%
cp310-cp310-musllinux_1_2_aarch64.whl 6.5 MB 10.8 MB 🔴 +66.42%
cp310-cp310-musllinux_1_2_x86_64.whl 7.2 MB 12.6 MB 🔴 +75.32%
cp310-cp310-win32.whl 6.4 MB 6.9 MB 🔴 +7.61%
cp310-cp310-win_amd64.whl 7.1 MB 7.7 MB 🔴 +8.76%
cp310-cp310-win_arm64.whl 2.5 MB 2.9 MB 🔴 +19.60%
cp311-cp311-macosx_10_10_x86_64.whl 5.4 MB 10.1 MB 🔴 +89.01%
cp311-cp311-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.67%
cp311-cp311-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp311-cp311-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp311-cp311-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.7 MB 🔴 +51.03%
cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.74%
cp311-cp311-musllinux_1_2_aarch64.whl 6.5 MB 10.8 MB 🔴 +66.32%
cp311-cp311-musllinux_1_2_x86_64.whl 7.2 MB 12.6 MB 🔴 +75.23%
cp311-cp311-win32.whl 6.4 MB 6.9 MB 🔴 +7.61%
cp311-cp311-win_amd64.whl 7.1 MB 7.7 MB 🔴 +8.76%
cp311-cp311-win_arm64.whl 2.5 MB 2.9 MB 🔴 +19.60%
cp312-cp312-macosx_10_13_x86_64.whl 5.3 MB 10.0 MB 🔴 +88.05%
cp312-cp312-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.68%
cp312-cp312-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp312-cp312-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp312-cp312-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.7 MB 🔴 +51.00%
cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.68%
cp312-cp312-musllinux_1_2_aarch64.whl 6.5 MB 10.8 MB 🔴 +66.25%
cp312-cp312-musllinux_1_2_x86_64.whl 7.2 MB 12.6 MB 🔴 +75.14%
cp312-cp312-win32.whl 6.4 MB 6.9 MB 🔴 +7.60%
cp312-cp312-win_amd64.whl 7.1 MB 7.7 MB 🔴 +8.76%
cp312-cp312-win_arm64.whl 2.5 MB 2.9 MB 🔴 +19.60%
cp313-cp313-ios_13_0_arm64_iphoneos.whl 4.1 MB 4.1 MB 🟡 +0.08%
cp313-cp313-ios_13_0_arm64_iphonesimulator.whl 4.2 MB 4.2 MB 🟡 +0.08%
cp313-cp313-ios_13_0_x86_64_iphonesimulator.whl 3.6 MB 3.6 MB 🟡 +0.11%
cp313-cp313-macosx_10_13_x86_64.whl 5.3 MB 10.0 MB 🔴 +88.05%
cp313-cp313-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.68%
cp313-cp313-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp313-cp313-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.7 MB 🔴 +51.03%
cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.73%
cp313-cp313-musllinux_1_2_aarch64.whl 6.5 MB 10.8 MB 🔴 +66.29%
cp313-cp313-musllinux_1_2_x86_64.whl 7.2 MB 12.6 MB 🔴 +75.18%
cp313-cp313-win32.whl 6.4 MB 6.9 MB 🔴 +7.61%
cp313-cp313-win_amd64.whl 7.1 MB 7.7 MB 🔴 +8.76%
cp313-cp313-win_arm64.whl 2.5 MB 2.9 MB 🔴 +19.60%
cp313-cp313t-macosx_10_13_x86_64.whl 5.3 MB n/a n/a
cp313-cp313t-macosx_11_0_arm64.whl 4.7 MB n/a n/a
cp313-cp313t-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp313-cp313t-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp313-cp313t-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB n/a n/a
cp313-cp313t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB n/a n/a
cp313-cp313t-musllinux_1_2_aarch64.whl 6.5 MB n/a n/a
cp313-cp313t-musllinux_1_2_x86_64.whl 7.2 MB n/a n/a
cp313-cp313t-win32.whl 6.4 MB n/a n/a
cp313-cp313t-win_amd64.whl 7.1 MB n/a n/a
cp313-cp313t-win_arm64.whl 2.5 MB n/a n/a
cp314-cp314-ios_13_0_arm64_iphoneos.whl 4.1 MB 4.1 MB 🟡 +0.08%
cp314-cp314-ios_13_0_arm64_iphonesimulator.whl 4.2 MB 4.2 MB 🟡 +0.08%
cp314-cp314-ios_13_0_x86_64_iphonesimulator.whl 3.6 MB 3.6 MB 🟡 +0.10%
cp314-cp314-macosx_10_15_x86_64.whl 5.3 MB 10.0 MB 🔴 +88.02%
cp314-cp314-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.68%
cp314-cp314-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp314-cp314-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp314-cp314-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.7 MB 🔴 +51.02%
cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.72%
cp314-cp314-musllinux_1_2_aarch64.whl 6.5 MB 10.8 MB 🔴 +66.28%
cp314-cp314-musllinux_1_2_x86_64.whl 7.2 MB 12.6 MB 🔴 +75.17%
cp314-cp314-win32.whl 6.5 MB 7.0 MB 🔴 +7.66%
cp314-cp314-win_amd64.whl 7.2 MB 7.9 MB 🔴 +8.85%
cp314-cp314-win_arm64.whl 2.6 MB 3.1 MB 🔴 +19.76%
cp314-cp314t-macosx_10_15_x86_64.whl 5.3 MB 10.0 MB 🔴 +87.99%
cp314-cp314t-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +59.64%
cp314-cp314t-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 6.3 MB n/a n/a
cp314-cp314t-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 8.1 MB n/a n/a
cp314-cp314t-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 6.4 MB 9.7 MB 🔴 +50.73%
cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 7.1 MB 11.4 MB 🔴 +60.43%
cp314-cp314t-musllinux_1_2_aarch64.whl 6.5 MB 10.9 MB 🔴 +65.95%
cp314-cp314t-musllinux_1_2_x86_64.whl 7.2 MB 12.7 MB 🔴 +74.87%
cp314-cp314t-win32.whl 6.5 MB 7.0 MB 🔴 +7.66%
cp314-cp314t-win_amd64.whl 7.2 MB 7.9 MB 🔴 +8.85%
cp314-cp314t-win_arm64.whl 2.6 MB 3.1 MB 🔴 +19.75%
pp311-pypy311_pp73-macosx_10_15_x86_64.whl 5.3 MB 9.9 MB 🔴 +88.65%
pp311-pypy311_pp73-macosx_11_0_arm64.whl 4.7 MB 7.5 MB 🔴 +60.13%
pp311-pypy311_pp73-manylinux2014_aarch64.manylinux_2_17_aarch64.whl 5.3 MB n/a n/a
pp311-pypy311_pp73-manylinux2014_x86_64.manylinux_2_17_x86_64.whl 7.0 MB n/a n/a
pp311-pypy311_pp73-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 5.4 MB 8.6 MB 🔴 +60.69%
pp311-pypy311_pp73-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 6.0 MB 10.3 MB 🔴 +71.43%
pp311-pypy311_pp73-win_amd64.whl 7.1 MB 7.7 MB 🔴 +8.76%
wheel average (65 wheels) 5.7 MB 8.4 MB 🔴 +46.83%
wheel total (65 wheels) 371.8 MB 545.9 MB 🔴 +46.83%
artifacts total (66 artifacts) 418.8 MB 593.3 MB 🔴 +41.68%

https://github.com/python-pillow/Pillow/actions/runs/25698618068/attempts/3#summary-75485821427

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
radarhere radarhere left review comments
+1 more reviewer
brunoais brunoais left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

JPEG

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL