Open 16-bit grayscale PNGs as I;16 - #7849
Merged
hugovk merged 1 commit intoMar 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Mar 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3796
#3041 originally asked why PNGs were opened in I mode rather than I;16, and the response was
Nevertheless, #3796 was opened, and has received various comments.
The one I find compelling is #3041 (comment)
Looking through our test images, it is true that 12bit.cropped.tif is opened as I;16, 16bit.MM.cropped.tif is I;16B and 16bit.cropped.j2k is I;16. So some consistency would be good.
This PR changes PNG to open as I;16 rather than I.