Deprecate non-image ImageCms modes - #8031
Merged
hugovk merged 1 commit intoJun 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Closed
radarhere
force-pushed
the
imagingcms_modes
branch
from
24530d5 to
d5fe3a7
Compare
April 30, 2024 08:20
radarhere
force-pushed
the
imagingcms_modes
branch
from
38047cf to
f976939
Compare
May 19, 2024 21:39
radarhere
force-pushed
the
imagingcms_modes
branch
from
0cf5495 to
eea3ac7
Compare
June 12, 2024 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8007
https://pillow.readthedocs.io/en/stable/reference/ImageCms.html#PIL.ImageCms.buildTransform and https://pillow.readthedocs.io/en/stable/reference/ImageCms.html#PIL.ImageCms.buildProofTransform describe inMode and outMode as
However, "RGBA;16B", "L;16", "L;16B", "YCCA" and "YCC" are modes that can be interpreted, and there is a default case if the mode is not recognised.
This deprecates modes that are not Pillow modes, and also deprecates the default value if the mode is not able to be mapped. I've also added I;16, I;16L, I;16B, YCbCr as possible replacement values.