FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

_imaging module cleanup by homm · Pull Request #8389 · python-pillow/Pillow · GitHub

/ Pillow Public

_imaging module cleanup - #8389

Closed
homm wants to merge 23 commits into
mainfrom
imaging-cleanup
ConversationCommits (23)ChecksFiles changed
Closed

_imaging module cleanup#8389
homm wants to merge 23 commits into
mainfrom
imaging-cleanup

Conversation

homm commented Sep 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Includes some useful changers from #8340.

Improvements

  • Move some useful macro such as MAX and MIN to ImagingUtils.h 517f16b
  • ImPlatform.h is renamed to ImagingPlatform.h d73e8c2
  • All #undef *INT* moved to Jpeg.h 8909052
  • Simplify #define *INT* by requiring stdint.h (C99) 92bf691
  • #include <Python.h> once in Imaging.h 84f0261
  • #include <math.h> in ImagingPlatform.h fbd4c98
  • Include all global libs with <*.h> instead of "*.h" 108602b
  • Removed add-imaging-libs option (is not documented, not sure why we need it) c3172e8
  • Use native functions instead of PyImaging_CheckBuffer and PyImaging_GetBuffer e972962
  • Use Py_RETURN_NONE macro when possible f58cd7d
  • Remove unused HAVE_LIBMPEG ffa0230
  • Move new_block method to _imaging and fix some functions arguments type e7bce42
  • Remove unused core.convert function e7bce42
  • Simplify Imaging_Type checking in _convert b89f791
  • Use PyErr_Format instead of sprintf, use native PyErr_Clear function, remove extra PyExc_TypeError after PySequence_Fast, remove unused Except.c file 05a67d1

radarhere reviewed Sep 18, 2024
View reviewed changes
Comment thread src/libImaging/Jpeg.h Outdated
homm commented Sep 18, 2024
View reviewed changes
Comment thread src/libImaging/Draw.c
#include "Imaging.h"

#include <math.h>
#include <stdint.h>

homm Sep 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One of the reason I think we can rely on C99 is stdint.h was included here unconditionally.

Yay295 Sep 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The default standard used by GCC on CentOS 7 was gnu90, which is not C99, but does support stdint.h. CentOS 7 is no longer supported though. The conclusion from this discussion (#6516) was essentially that if it compiles in all of the test environments, it's okay to use.

Comment thread src/libImaging/ImPlatform.h
#endif
#endif

#if defined(_WIN32) || defined(__CYGWIN__) /* WIN */

homm Sep 18, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I will examine this and return if needed:
#5807

radarhere Sep 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I'm not completely clear on your meaning - reconsidering this change is a to-do item for yourself before this PR is ready for merge?

radarhere reviewed Sep 27, 2024
View reviewed changes
Comment thread src/_imagingcms.c Outdated
homm and others added 16 commits October 7, 2024 18:54
MIN and MAX macros in ImagingUtils
7b31791
Rename ImPlarform to ImagingPlatform
f4accfe
Remove tiff extra guards
c46ff64
Cleanup Jpeg.h undefs
2a7c967
Drop support of not C99+ compilers (including old MSVC)
34488d1
Move include Python.h to ImagingPlatform
ff7c29c
Move import math.h to ImagingPlatform
039869f
Remove add-imaging-libs option
bd03721 
# Conflicts:
#	setup.py
import global libs correctly
517c3e1
Remove obsolete PyImaging_CheckBuffer and PyImaging_GetBuffer
310f625
Use Py_RETURN_NONE macro when possible
24daafa
Remove unused declaration
8ba076a
Correct types of _imaging methods
50dd946 
Move new_block method to _imaging
remove _imaging.convert method
Fix Imaging_Type check in _convert
3a16a35
Cleanup exceptions handling
37b2a1b 
Remove unused module
Remove ImagingError_Clear alias
Do not set PyExc_TypeError after PySequence_Fast
Remove ImagingError_OSError alias
Use PyErr_Format when possible
Update comment [ci skip]
5e07d85 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
homm force-pushed the imaging-cleanup branch from 9ec3c03 to 5e07d85 Compare October 7, 2024 15:10
Update comment
001ee31 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere mentioned this pull request Jan 27, 2025
Merged
radarhere mentioned this pull request Jun 15, 2025
Merged
This was referenced Jan 3, 2026
Closed
Merged

radarhere commented Jan 4, 2026

Copy link
Copy Markdown
Member

Just tracking the progress on this.

ImPlatform.h is renamed to ImagingPlatform.h d73e8c2

I've created #9377

Removed add-imaging-libs option (is not documented, not sure why we need it) c3172e8

Merged in #9378

Use Py_RETURN_NONE macro when possible f58cd7d

Merged in #8717

Remove unused HAVE_LIBMPEG ffa0230

Merged in #8717

Use PyErr_Format instead of sprintf, use native PyErr_Clear function, remove extra PyExc_TypeError after PySequence_Fast, remove unused Except.c file 05a67d1

#8717 and #9021 cover parts of this.

akx mentioned this pull request Jul 20, 2026
Merged
espressolee mentioned this pull request Aug 5, 2026
Open
radarhere mentioned this pull request Aug 27, 2026
Merged
radarhere mentioned this pull request Aug 27, 2026
Merged
radarhere mentioned this pull request Aug 28, 2026
Merged

radarhere commented Aug 29, 2026

Copy link
Copy Markdown
Member

Closing.

Many of the changes from this have been merged. If there's anything left here that you think should still be included, please leave a comment explaining why.

radarhere closed this Aug 29, 2026
radarhere deleted the imaging-cleanup branch August 29, 2026 00:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

radarhere radarhere left review comments
+1 more reviewer
Yay295 Yay295 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Needs Rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL