FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve type checking in tests by radarhere · Pull Request #8618 · python-pillow/Pillow · GitHub

Improve type checking in tests - #8618

Merged
hugovk merged 4 commits into
python-pillow:mainfrom
radarhere:px
Feb 17, 2025
Merged

Improve type checking in tests#8618
hugovk merged 4 commits into
python-pillow:mainfrom
radarhere:px

Conversation

Copy link
Copy Markdown
Member

This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.

In our test suite, this PR

  • asserts that a tuple is returned by getpixel(), rather than float or None, before index access is used

Pillow/src/PIL/Image.py

Lines 1680 to 1682 in 0e3f51d

def getpixel(
self, xy: tuple[int, int] | list[int]
) -> float | tuple[int, ...] | None:

  • asserts that load() does not return None before pixel access is used

def load(self) -> core.PixelAccess | None:

  • assert that palette is not None before trying to access one of its properties

self.palette: ImagePalette.ImagePalette | None = None

hugovk merged commit 1754125 into python-pillow:main Feb 17, 2025
radarhere deleted the px branch February 17, 2025 20:50
radarhere mentioned this pull request Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL