Corrected loadImageSeries type hint by radarhere · Pull Request #8624 · python-pillow/Pillow · GitHub

This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.

Two changes to loadImageSeries.

Lines 214 to 233 in 0e3f51d

    
           def loadImageSeries(filelist: list[str] | None = None) -> list[SpiderImageFile] | None: 
        
               """create a list of :py:class:`~PIL.Image.Image` objects for use in a montage""" 
        
               if filelist is None or len(filelist) < 1: 
        
                   return None 
        
               imglist = [] 
        
               for img in filelist: 
        
                   if not os.path.exists(img): 
        
                       print(f"unable to find {img}") 
        
                       continue 
        
                   try: 
        
                       with Image.open(img) as im: 
        
                           im = im.convert2byte() 
        
                   except Exception: 
        
                       if not isSpiderImage(img): 
        
                           print(f"{img} is not a Spider image file") 
        
                       continue 
        
                   im.info["filename"] = img 
        
                   imglist.append(im) 
        
               return imglist

convert2byte() is a SpiderImageFile method, so the image must be a SPIDER image to call that
convert2byte() returns an Image instance, meaning that loadImageSeries returns a list of Images, not SpiderImageFiles.

Pillow/src/PIL/SpiderImagePlugin.py

Line 189 in 0e3f51d

def convert2byte(self, depth: int = 255) -> Image.Image:

Corrected loadImageSeries type hint

622722f

radarhere added the Type hints label Dec 26, 2024

hugovk merged commit f9767fb into python-pillow:main Dec 26, 2024

radarhere deleted the type_hint_spider branch December 26, 2024 23:53

Corrected loadImageSeries type hint by radarhere · Pull Request #8624 · python-pillow/Pillow · GitHub

Uh oh!

Uh oh!

Corrected loadImageSeries type hint - #8624

Corrected loadImageSeries type hint#8624
hugovk merged 1 commit into
python-pillow:mainfrom
radarhere:type_hint_spider

radarhere commented Dec 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	def loadImageSeries(filelist: list[str] \| None = None) -> list[SpiderImageFile] \| None:
	"""create a list of :py:class:`~PIL.Image.Image` objects for use in a montage"""
	if filelist is None or len(filelist) < 1:
	return None

	imglist = []
	for img in filelist:
	if not os.path.exists(img):
	print(f"unable to find {img}")
	continue
	try:
	with Image.open(img) as im:
	im = im.convert2byte()
	except Exception:
	if not isSpiderImage(img):
	print(f"{img} is not a Spider image file")
	continue
	im.info["filename"] = img
	imglist.append(im)
	return imglist

Corrected loadImageSeries type hint by radarhere · Pull Request #8624 · python-pillow/Pillow · GitHub

Uh oh!

Uh oh!

Corrected loadImageSeries type hint - #8624

Corrected loadImageSeries type hint#8624hugovk merged 1 commit intopython-pillow:mainpython-pillow/Pillow:mainfrom radarhere:type_hint_spiderradarhere/Pillow:type_hint_spiderCopy head branch name to clipboard

Conversation

radarhere commented Dec 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Corrected loadImageSeries type hint#8624
hugovk merged 1 commit into
python-pillow:mainfrom
radarhere:type_hint_spider