Pass file handle to ContainerIO by radarhere · Pull Request #8625 · python-pillow/Pillow · GitHub

This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.

#7656 set ContainerIO to receive IO as the type of the first argument.

Line 29 in f9767fb

def __init__(self, file: IO[AnyStr], offset: int, length: int) -> None:

Currently, test_file_container.py passes an image instance to it sometimes - the wrong type.

Lines 18 to 19 in f9767fb

    
           with hopper() as im: 
        
               container = ContainerIO.ContainerIO(im, 0, 0)

This PR fixes that, passing a file handle to it like the rest of the test file does.

Lines 41 to 42 in f9767fb

    
           with open(TEST_FILE, "rb") as fh: 
        
               container = ContainerIO.ContainerIO(fh, 22, 100)

radarhere added Testing Type hints labels Dec 27, 2024

Pass file handle to ContainerIO

aef3aa2

radarhere force-pushed the containerio branch from b701469 to aef3aa2 Compare December 27, 2024 00:26

hugovk merged commit d008d12 into python-pillow:main Dec 27, 2024

radarhere deleted the containerio branch December 27, 2024 19:52

Pass file handle to ContainerIO - #8625

	with hopper() as im:
	container = ContainerIO.ContainerIO(im, 0, 0)

	with open(TEST_FILE, "rb") as fh:
	container = ContainerIO.ContainerIO(fh, 22, 100)