Rewrite the install_name of the ZLIB-NG library on macOS - #8673
Merged
radarhere merged 2 commits intoFeb 15, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Jan 8, 2025
Copy link
Copy Markdown
Contributor
Author
|
I believe #8743 is an even better solution, as it fixes the problem at the source; and, with any luck, eventually the patch won't be needed. |
Sorry, something went wrong.
hugovk
approved these changes
Feb 15, 2025
Copy link
Copy Markdown
Member
|
I've created #9312 to upgrade to zlib-ng 2.3.1, which now includes zlib-ng/zlib-ng#1867. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: I believe #8743 is an even better solution, as it fixes the problem at the source.
Fixes #8671. Alternative to #8672
Changes proposed in this pull request:
When zlib-ng is compiled, it sets the install name of the libz.1.dylib to @rpath/libz.1.dylib. This means that any subsequent load requires a valid DYLD_LIBRARY_PATH to resolve the link.
Recent versions of macOS have a feature called System Integrity Protection (SIP) which (amongst other things) prevents DYLD_LIBRARY_PATH from being passed into subshells. As the build's dependencies aren't on the default library path on macOS, delocate-wheel is unable to resolve the libz library.
SIP is disabled on GitHub Actions configurations, so this problem isn't seen in CI; but is enabled by default on macOS machines, so individual developers building Pillow dependencies will get an error from cibuildwheel when the wheel is repaired.
By making the install_name of libz an absolute path, it removes the need to dynamically resolve the path.