Remove Sphinx dependency from mypy - #9370
Conversation
Sorry, something went wrong.
radarhere
left a comment
There was a problem hiding this comment.
An alternative solution would be to revert #9364 and then pin Sphinx to 9.0.4 for now. However, I suspect you would, very reasonably, prefer to use the latest version of Sphinx and not be held back by type hints.
I will also note that we could bring back the Sphinx dependency when Python 3.11 becomes EOL at the end of next year.
Sorry, something went wrong.
Yeah, I think it's cleaner not to pin an old Sphinx for type hints, and use a newer version for building the docs. The hints don't really tell us much here, and doc/ isn't part of our production code.
By then, Sphinx will likely be on 3.13+: https://www.sphinx-doc.org/en/master/internals/release-process.html#python-version-support-policy |
Sorry, something went wrong.
Follow on from #9364.
tox -e mypy was still failing for me because it uses my machine's default Python version, currently 3.14.
We could pin tox to 3.10 as well for mypy, but that requires installing 3.10 locally, and we only require Sphinx for type checking doc/dater.py, and the Sphinx types don't really add much.