Catch OSError for FreeType >= 2.14.0 - #9481
Closed
radarhere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I am closing this in favour of #9483 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #8324 was merged, the modified test has started failing in main - https://github.com/python-pillow/Pillow/actions/runs/23347044302/job/67915216500#step:13:2864
Testing, I find that FreeType 2.13.3 passes, but for FreeType >= 2.14.0, FT_New_Face() returns Invalid_File_Format, a.k.a "broken file". The test file is a font generated by OSS-Fuzz though, so there is no reason it has to be a valid file.
I've updated the test to specifically catch "broken file" for FreeType >= 2.14.0.
As background, the test was originally added in #6846. Coincidentally, it also had a with pytest.raises(OSError):, intending to catch a "Bitmap missing for glyph" error raised by Pillow, but #8324 removed the error itsell.