FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove Setuptools obsolete `zip_safe` flag by hugovk · Pull Request #9758 · python-pillow/Pillow · GitHub

/ Pillow Public

Remove Setuptools obsolete zip_safe flag - #9758

Merged
radarhere merged 1 commit into
python-pillow:mainfrom
hugovk:rm-zip_safe
Jul 3, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Remove Setuptools obsolete zip_safe flag#9758
radarhere merged 1 commit into
python-pillow:mainfrom
hugovk:rm-zip_safe

Conversation

hugovk commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

https://setuptools.pypa.io/en/latest/deprecated/zip_safe.html says:

The zip_safe flag is a setuptools configuration mainly associated with the egg distribution format (which got replaced in the ecosystem by the newer wheel format) and the easy_install command (deprecated in setuptools v58.3.0).

It is very unlikely that the values of zip_safe will affect modern deployments that use pip for installing packages. Moreover, new users of setuptools should not attempt to create egg files using the deprecated build_egg command. Therefore, this flag is considered obsolete.

We require setuptools>=77:

Pillow/pyproject.toml

Line 5 in bb1d8e8

"setuptools>=77",

hugovk added Cleanup Packaging Any mention of setup.py; some overlap with Install label labels Jul 3, 2026
hugovk changed the title Remove SetupTools obsolete zip_safe flag Remove Setuptools obsolete zip_safe flag Jul 3, 2026

codspeed-hq Bot commented Jul 3, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 95.74%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 36 improved benchmarks
✅ 309 untouched benchmarks
⏩ 2 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_chops[1024x1024-LA-add_modulo] 18.6 ms 6.5 ms ×2.8
⚡ test_chops[1024x1024-RGBA-add_modulo] 18.6 ms 6.5 ms ×2.8
⚡ test_chops[1024x1024-RGB-add_modulo] 18.6 ms 6.5 ms ×2.8
⚡ test_chops[1024x1024-L-add_modulo] 4.7 ms 1.7 ms ×2.8
⚡ test_chops[1024x1024-LA-darker] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-LA-lighter] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-RGBA-lighter] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-RGBA-darker] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-RGB-lighter] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-RGB-darker] 26.8 ms 11 ms ×2.4
⚡ test_chops[1024x1024-L-lighter] 6.7 ms 2.8 ms ×2.4
⚡ test_chops[1024x1024-L-darker] 6.7 ms 2.8 ms ×2.4
⚡ test_chops[1024x1024-LA-add] 32.6 ms 14.1 ms ×2.3
⚡ test_chops[1024x1024-RGBA-add] 32.6 ms 14.1 ms ×2.3
⚡ test_chops[1024x1024-RGB-add] 32.6 ms 14.1 ms ×2.3
⚡ test_chops[1024x1024-L-add] 8.2 ms 3.6 ms ×2.3
⚡ test_chops[1024x1024-LA-subtract] 29.1 ms 14.4 ms ×2
⚡ test_chops[1024x1024-RGBA-subtract] 29.1 ms 14.4 ms ×2
⚡ test_chops[1024x1024-RGB-subtract] 29.1 ms 14.4 ms ×2
⚡ test_chops[1024x1024-L-subtract] 7.3 ms 3.7 ms ×2
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing hugovk:rm-zip_safe (8a3a05f) with main (07e9a6c)2

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (c64a82f) during the generation of this report, so 07e9a6c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

radarhere merged commit 1cf685c into python-pillow:main Jul 3, 2026
93 of 95 checks passed
hugovk deleted the rm-zip_safe branch July 3, 2026 12:19

aclark4life commented Jul 3, 2026

Copy link
Copy Markdown
Member

Can we include #9645 in the next release?

hugovk commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Replied at #9643 (comment).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

radarhere radarhere approved these changes

Assignees

No one assigned

Labels

Cleanup Packaging Any mention of setup.py; some overlap with Install label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL