FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Speed up `Image.filter()` for `I;16*` by akx · Pull Request #9760 · python-pillow/Pillow · GitHub

/ Pillow Public

Speed up Image.filter() for I;16* - #9760

Open
akx wants to merge 10 commits into
python-pillow:mainfrom
akx:faster-filter-still
ConversationCommits (10)ChecksFiles changed
Open

Speed up Image.filter() for I;16*#9760
akx wants to merge 10 commits into
python-pillow:mainfrom
akx:faster-filter-still

Conversation

akx commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follows up on #8438; same split-by-mode optimization technique as in #9737.

Also fixes up things around ImageFilter:

  • the tests' modes list was N-plicated
  • the test_consistency_* tests didn't use the mode parametrization at all and just ran the same test N times
  • test_crash claimed ImageFilter would crash on images smaller than the kernel; it doesn't, it just returns the same image.
    • Looks like test_crash had had assert_no_exception sometime before 3ec5059?
  • The docstring for Kernel claimed only a couple of modes were supported.

The correctness bugs from #9786 are fixed here too.

codspeed-hq Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by ×2.5

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 553 untouched benchmarks
⏩ 335 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_filter[1237x811-L-Smooth] 23.2 ms 9.5 ms ×2.5
⚡ test_filter[1237x811-L-Sharpen] 23.2 ms 9.5 ms ×2.4

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing akx:faster-filter-still (bcb47ed) with main (3220aca)

Footnotes

  1. 335 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This comment was marked as outdated.

Sign in to view
akx force-pushed the faster-filter-still branch 3 times, most recently from e2022ed to 525c545 Compare July 3, 2026 19:21
akx commented Jul 4, 2026
View reviewed changes
Comment thread Tests/test_image_filter.py Outdated
akx force-pushed the faster-filter-still branch 4 times, most recently from 3ca13f7 to 4666708 Compare July 5, 2026 13:50
akx marked this pull request as ready for review July 5, 2026 14:07
akx mentioned this pull request Jul 6, 2026
Draft
akx force-pushed the faster-filter-still branch from 4666708 to 820171b Compare July 6, 2026 13:56
akx mentioned this pull request Jul 7, 2026
Open
akx marked this pull request as draft July 9, 2026 10:15
akx force-pushed the faster-filter-still branch 3 times, most recently from c448421 to 7ce5129 Compare July 9, 2026 12:01
akx changed the title Speed up Image.filter() for I;16* Speed up + bugfix Image.filter() for I;16* Jul 9, 2026
akx mentioned this pull request Jul 9, 2026
Merged
akx force-pushed the faster-filter-still branch from 7ce5129 to fcfbd51 Compare July 9, 2026 12:10
akx marked this pull request as ready for review July 9, 2026 15:16
akx marked this pull request as draft July 17, 2026 08:08

This comment was marked as resolved.

Sign in to view
akx force-pushed the faster-filter-still branch from fcfbd51 to 5fa9eee Compare July 18, 2026 10:25
akx marked this pull request as ready for review July 19, 2026 13:12
akx changed the title Speed up + bugfix Image.filter() for I;16* Speed up Image.filter() for I;16* Jul 19, 2026
akx mentioned this pull request Jul 29, 2026
Merged

hugovk commented Aug 9, 2026

Copy link
Copy Markdown
Member

Updated from main following benchmark image update: #9831.

akx force-pushed the faster-filter-still branch 4 times, most recently from 3dbd362 to 14c9690 Compare August 10, 2026 19:12
radarhere reviewed Aug 15, 2026
View reviewed changes
Comment thread src/libImaging/Filter.c
}
} else {
} else if (im->type == IMAGING_TYPE_SPECIAL) {
// Check for I;16 mode once, not per pixel

radarhere Aug 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Check for I;16 mode once, not per pixel

Once this is merged, I don't think it's obvious what the comment is referring to

radarhere reviewed Aug 15, 2026
View reviewed changes
Comment thread src/libImaging/Filter.c
}
} else {
} else if (im->type == IMAGING_TYPE_SPECIAL) {
// Check for I;16 mode once, not per pixel

radarhere Aug 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// Check for I;16 mode once, not per pixel

radarhere mentioned this pull request Aug 15, 2026
Merged
akx force-pushed the faster-filter-still branch from bcb47ed to 80b9256 Compare August 20, 2026 06:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

radarhere radarhere left review comments

Assignees

No one assigned

Labels

Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL