FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Speed up `Image.getbbox()`; fix it for I;16 modes by akx · Pull Request #9768 · python-pillow/Pillow · GitHub

/ Pillow Public

Speed up Image.getbbox(); fix it for I;16 modes - #9768

Open
akx wants to merge 5 commits into
python-pillow:mainfrom
akx:unbound
ConversationCommits (5)ChecksFiles changed
Open

Speed up Image.getbbox(); fix it for I;16 modes#9768
akx wants to merge 5 commits into
python-pillow:mainfrom
akx:unbound

Conversation

akx commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hoist/restrict and autovectorization optimizations for getbbox().

A review also showed that I;16 modes weren't correctly supported by this function (they were iterating over int8), so that got fixed too. I know it's bad form to mix optimizations and bugfixes into one PR, but the bugfix would have required the const type* row = ... hoist assignments anyhow.

-------------------------- benchmark 'bbox': 20 tests, 2 sources ---------------------------
Name (time in us)                               0001_40ea9a1 Min  0002_d07694f Min      ΔMin
--------------------------------------------------------------------------------------------
test_getbbox[1024x1024-L-half-corner]                   226.7091           10.9579    -95.2%
test_getbbox[1024x1024-RGB-half-corner]                 229.2499           38.2080    -83.3%
test_getbbox[1024x1024-RGBA-half-corner]                229.3329           40.5840    -82.3%
test_getbbox[1024x1024-LA-half-corner]                  230.6249           38.2080    -83.4%
test_getbbox[1024x1024-I;16-half-centered]              231.0410           21.3749    -90.7%
test_getbbox[1024x1024-L-half-centered]                 240.4579           11.3329    -95.3%
test_getbbox[1024x1024-RGBA-half-centered]              249.7090           44.7499    -82.1%
test_getbbox[1024x1024-LA-half-centered]                249.8330           41.2500    -83.5%
test_getbbox[1024x1024-RGB-half-centered]               251.2090           41.9160    -83.3%
test_getbbox[1024x1024-L-empty]                         295.4580           11.4590    -96.1%
test_getbbox[1024x1024-L-small-centered]                297.5831           12.5830    -95.8%
test_getbbox[1024x1024-LA-empty]                        298.1250           43.9170    -85.3%
test_getbbox[1024x1024-RGB-empty]                       298.1250           47.5419    -84.1%
test_getbbox[1024x1024-RGBA-empty]                      298.1670           47.0839    -84.2%
test_getbbox[1024x1024-I;16-small-centered]             299.1251           24.1250    -91.9%
test_getbbox[1024x1024-I;16-empty]                      300.4170           21.9160    -92.7%
test_getbbox[1024x1024-I;16-half-corner]                301.2920           19.0841    -93.7%
test_getbbox[1024x1024-LA-small-centered]               304.9170           51.2920    -83.2%
test_getbbox[1024x1024-RGB-small-centered]              305.0419           54.7920    -82.0%
test_getbbox[1024x1024-RGBA-small-centered]             305.0419           50.4589    -83.5%
--------------------------------------------------------------------------------------------

akx force-pushed the unbound branch 3 times, most recently from 91b85ba to 223df15 Compare July 5, 2026 16:47
akx changed the title Speed up Image.getbbox() Speed up Image.getbbox(); fix it for I;16 modes Jul 5, 2026
akx marked this pull request as ready for review July 5, 2026 18:46
radarhere reviewed Jul 6, 2026
View reviewed changes
Comment thread Tests/test_image_getbbox.py Outdated
radarhere reviewed Jul 18, 2026
View reviewed changes
Comment thread Tests/test_image_getbbox.py
akx force-pushed the unbound branch 2 times, most recently from 17b2185 to 50e27a2 Compare July 21, 2026 10:56
akx mentioned this pull request Jul 29, 2026
Merged

codspeed-hq Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 96.24%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 20 improved benchmarks
✅ 535 untouched benchmarks
⏩ 335 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_getbbox[1237x811-L-empty] 2,159.1 µs 605.7 µs ×3.6
⚡ test_getbbox[1237x811-L-small-centered] 2,156.9 µs 608.5 µs ×3.5
⚡ test_getbbox[1237x811-L-half-centered] 1,682.7 µs 492.3 µs ×3.4
⚡ test_getbbox[1237x811-L-half-corner] 1,646.1 µs 488.8 µs ×3.4
⚡ test_getbbox[1237x811-I;16-half-corner] 2,182.3 µs 903.6 µs ×2.4
⚡ test_getbbox[1237x811-I;16-empty] 2.2 ms 1.2 ms +87.59%
⚡ test_getbbox[1237x811-I;16-small-centered] 2.2 ms 1.2 ms +86.89%
⚡ test_getbbox[1237x811-I;16-half-centered] 1,655.3 µs 905.7 µs +82.76%
⚡ test_getbbox[1237x811-RGBA-half-centered] 2.9 ms 1.8 ms +62.33%
⚡ test_getbbox[1237x811-RGB-half-centered] 2.9 ms 1.8 ms +62.33%
⚡ test_getbbox[1237x811-LA-half-centered] 2.9 ms 1.8 ms +62.33%
⚡ test_getbbox[1237x811-RGB-small-centered] 3.8 ms 2.3 ms +62.12%
⚡ test_getbbox[1237x811-RGBA-small-centered] 3.8 ms 2.3 ms +62.11%
⚡ test_getbbox[1237x811-LA-small-centered] 3.8 ms 2.3 ms +62.07%
⚡ test_getbbox[1237x811-RGB-empty] 3.8 ms 2.4 ms +61.91%
⚡ test_getbbox[1237x811-LA-empty] 3.8 ms 2.4 ms +61.91%
⚡ test_getbbox[1237x811-RGBA-empty] 3.8 ms 2.4 ms +61.91%
⚡ test_getbbox[1237x811-LA-half-corner] 2.9 ms 1.8 ms +60.32%
⚡ test_getbbox[1237x811-RGB-half-corner] 2.9 ms 1.8 ms +60.32%
⚡ test_getbbox[1237x811-RGBA-half-corner] 2.9 ms 1.8 ms +60.31%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing akx:unbound (2a5ef4c) with main (3220aca)

Footnotes

  1. 335 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

radarhere reviewed Aug 20, 2026
View reviewed changes
Comment thread src/libImaging/GetBBox.c Outdated
Reword comment
2a5ef4c 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

radarhere radarhere left review comments

Assignees

No one assigned

Labels

Performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL