Port coveragerc to pyproject.toml; omit benchmarks from coverage - #9771
Merged
hugovk merged 4 commits intoJul 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
It isn't run under coverage testing in CI, so it gives false negatives
akx
marked this pull request as ready for review
July 5, 2026 18:53
hugovk
reviewed
Jul 5, 2026
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Turns out I had a branch to do this earlier this year (except of course not the benchmarks.py bit), but never got round to opening the PR :)
Here's the other things I was going to include.
Sorry, something went wrong.
Comment thread
pyproject.toml
Outdated
Comment thread
pyproject.toml
Outdated
Comment thread
pyproject.toml
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
radarhere
reviewed
Jul 6, 2026
Comment thread
pyproject.toml
Outdated
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says in the commits and on the tin; I noticed Codecov (rightly) said benchmarks.py is at zero coverage.
While at it, ported .coveragerc to the pyproject.toml format for one less loose config file in the repo root.