Warn about duplicate Raqm text preprocessing - #9914
Closed
cananoo wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
cananoo
marked this pull request as ready for review
August 28, 2026 02:38
Copy link
Copy Markdown
Member
|
Hi. Do you have any thoughts on #9925, an alternative that has been created? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I reviewed #9925. It covers the same underlying Raqm double-processing behavior, and I agree it should be the canonical fix rather than landing duplicate warnings. I am happy for #9925 to proceed and can close #9914 if you prefer; please let me know. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The creator of the original issue made the other PR, so if you're happy, then I think it makes sense to go with that. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9907. Alternative to #9925
Pillow uses libraqm to perform shaping and bidirectional text layout when it is available. This adds a note to the ImageDraw documentation warning that pre-processing text with arabic_reshaper and python-bidi in that case applies the same processing twice and can produce incorrect output.
The note also points readers to PIL.features.check("raqm") so applications can choose the appropriate behavior at runtime.
Validation:
I used OpenAI Codex to assist with investigating and preparing this change, and reviewed the resulting documentation before submission.