Login and push to dockerhub - #40
Merged
wiredfool merged 7 commits intoDec 27, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
wiredfool
force-pushed
the
docker-login
branch
from
443d03b to
ea3906e
Compare
December 27, 2018 11:47
hugovk
reviewed
Dec 28, 2018
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for this!
And rather than sharing a password, https://docs.docker.com/docker-hub/orgs/ might be a better way.
Sorry, something went wrong.
Comment thread
.travis.yml
| ; fi | ||
| - make build && make test | ||
| after_success: | ||
| - if [[ "$TRAVIS_BRANCH" == "master" ]]; then make push ; fi |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
$TRAVIS_BRANCH is ambiguous depending on whether this is a PR or not, see:
https://graysonkoonce.com/getting-the-current-branch-name-during-a-pull-request-in-travis-ci/
This attempts an upload for PRs too. It needs an extra against $TRAVIS_PULL_REQUEST.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks. I've fixed the travis pull request thing, we can setup an org whenever. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login and push to docker hub on build to master (or at least, to master once it's been done and works on this branch)