Reviewer's Guide

Adjusts env activate to choose activation output based on detected shell instead of OS, unifies quoting/command construction across platforms (including POSIX shells on Windows), and updates/extends tests accordingly, including Windows + bash regression coverage.

Updated class diagram for env activate command and environment

classDiagram
    class EnvActivateCommand {
        _get_activate_command(env Env, shell str) str
        _quote(activation_script Path, shell str) str
    }

    class Env {
        bin_dir Path
    }

    class Path {
        as_posix() str
    }

    EnvActivateCommand --> Env : uses
    Env --> Path : bin_dir
    EnvActivateCommand --> Path : uses

File-Level Changes

Assessment against linked issues

Possibly linked issues

• poetry env activate does not work in Bash for Windows #10395: The PR changes env activate to be shell-based, fixing Bash-on-Windows behavior exactly as described in the issue.

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Thanks for the detailed review — agreed on all points.

I’ll update this PR accordingly:

• use shell-specific command tokening so PowerShell uses & and cmd stays empty
• remove the _quote-side & handling
• extend the existing parameterized tests instead of adding a separate one

I’ll push a follow-up revision that addresses the Windows failures.

Addressed the requested changes and pushed 5f427522.

What changed:

• powershell / pwsh now use & as the command token (instead of .)
• cmd now uses an empty command token (so output is just the quoted .bat path)
• removed & prefixing from _quote (so command tokening and quoting are separated)
• folded the Windows-bash case into the existing Windows parameterized test (removed the standalone test)

Validation run:

• poetry run pytest -o addopts='' tests/console/commands/env/test_activate.py -q
• result: 11 passed, 4 skipped

Pushed another follow-up: abe08c02.

Root cause of the Windows CI failures was assertion mismatch in the test expectations (actual output used single-quoted paths for pwsh/powershell/bash via shlex.quote).

Updates:

• adjusted Windows test expectations to match actual quoting behavior:
  • pwsh/powershell: & '{path}'
  • bash: source '{path}'
• small Ruff cleanup (SIM102) in _quote

Local verification:

• pre-commit run --files src/poetry/console/commands/env/activate.py tests/console/commands/env/test_activate.py
• poetry run pytest -o addopts='' tests/console/commands/env/test_activate.py -q
• result: 11 passed, 4 skipped

All requested fixes are now in and CI is fully green on commit abe08c02 (including the Windows pytest matrix).

Could you take another look when you have a moment?

@sourcery-ai review

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.