Lowercase the machine in wheel platform tags - #130
Merged
timkpaine merged 1 commit intoSep 7, 2026
Merged
timkpaine merged 1 commit into
timkpaine merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
platform.machine() returns "AMD64" (or "ARM64") on Windows, so wheels were tagged win_AMD64 instead of the PEP 425 lowercase win_amd64. pip tolerates this because packaging.tags.Tag lowercases on parse, but uv rejects the wheel as incompatible with the platform. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 95.81% 95.90% +0.09%
==========================================
Files 14 14
Lines 1266 1271 +5
==========================================
+ Hits 1213 1219 +6
+ Misses 53 52 -1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform.machine() returns "AMD64" (or "ARM64") on Windows, so wheels were tagged win_AMD64 instead of the PEP 425 lowercase win_amd64. pip tolerates this because packaging.tags.Tag lowercases on parse, but uv rejects the wheel as incompatible with the platform.
Description
Brief description of the changes in this PR.
Type of Change
Checklist