| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
It has been 90 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
Sorry, something went wrong.
Remove the default_bump_level setting from conventional-commit, scipy, and emoji parsers. - Removed default_bump_level field from ConventionalCommitParserOptions - Removed default_level_bump and default_bump_level from ScipyParserOptions - Removed default_bump_level field from EmojiParserOptions - Updated code to use LevelBump.NO_RELEASE directly instead of self.options.default_bump_level - Updated tag_to_level dict construction to use LevelBump.NO_RELEASE instead of default_bump_level - Updated tests to remove references to default_bump_level - Added new tests to verify parsers work correctly with other_allowed_tags BREAKING CHANGE: The `default_bump_level` configuration option has been removed from the conventional-commit, scipy, and emoji commit parsers. This option was redundant as the parser already maps commit types to bump levels. If you were using this option in your configuration, you can remove it. The parsers will now use LevelBump.NO_RELEASE for commit types not explicitly mapped to a bump level, which is the same behavior as the previous default. Co-authored-by: codejedi365 <17354856+codejedi365@users.noreply.github.com>
|
It has been 90 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Purpose
Remove the redundant default_bump_level configuration option from conventional-commit, scipy, and emoji parsers. The option duplicates functionality already provided by explicit commit type to bump level mappings.
Rationale
Each parser's tag_to_level mapping already defines bump levels for all recognized commit types. The default_bump_level was only used as a fallback in zip_longest operations during map construction—a confusing indirection that obscured actual behavior. Removing it eliminates configuration complexity without changing semantics: unrecognized commit types now explicitly receive LevelBump.NO_RELEASE instead of a configurable default.
Before:
After:
How did you test?
How to Verify
Run the test suite:
Check that parsers correctly assign NO_RELEASE to unmatched commit types without configuration errors.
PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)
BREAKING CHANGE: The default_bump_level option has been removed from conventional-commit, scipy, and emoji parser configurations. Remove this option from your pyproject.toml if present. Behavior unchanged: unrecognized commit types receive NO_RELEASE.
Closes #1293, #700
Original promptThis pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.